Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: TestStdlib is accidentally skipped #46027

Closed
findleyr opened this issue May 6, 2021 · 5 comments
Closed

go/types, types2: TestStdlib is accidentally skipped #46027

findleyr opened this issue May 6, 2021 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.17

Comments

@findleyr
Copy link
Member

findleyr commented May 6, 2021

I noticed that testing go/types had recently gone from 8s->1.5s, which bisected to https://golang.org/cl/276272.

That CL has a change to go/types' TestStdlib, which purports to skip submodules, but actually skips everything (src has a go.mod).

I'm not sure how that change relates to go/types, so I'm not sure if I can back out this modification.

CC @griesemer @FiloSottile @katiehockman
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) release-blocker labels May 6, 2021
@findleyr findleyr added this to the Go1.17 milestone May 6, 2021
@findleyr findleyr changed the title go/types: TestStdlib is accidentally skipped go/types, types2: TestStdlib is accidentally skipped May 6, 2021
@dmitshur
Copy link
Contributor

dmitshur commented May 6, 2021

Nicely spotted. Also CC @bcmills.

@findleyr
Copy link
Member Author

findleyr commented May 6, 2021

This also affects cmd/compile/internal/types2.

I guess the intent is to skip src/crypto/ed25519/internal/edwards25519/field/_asm. If that's necessary we should probably just skip that one directory, along with a more detailed explanation of why skipping is necessary.

@FiloSottile
Copy link
Contributor

Oh good catch! Sorry about that 😓

The skip was meant for nested, non-std/cmd submodules, which might not have all source vendored and available. I wanted to avoid special-casing that one module to make it easier to use modules to track versions of code generator tools (without shipping them and their entire dependency tree with the Go project, since that code doesn't contribute to the build.)

Feel free to fix that test however you see fit, or I will look into it tomorrow.

@findleyr findleyr added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 7, 2021
@findleyr
Copy link
Member Author

findleyr commented May 7, 2021

No worries, I'll send a fix.

For now I'll just skip this one module. If this type of thing becomes a pattern we can re-evaluate.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/317869 mentions this issue: go/types,cmd/compile/internal/types2: unskip std and cmd in TestStdlib

@dmitshur dmitshur mentioned this issue May 19, 2021
Closed
@golang golang locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@FiloSottile @dmitshur @gopherbot @findleyr