Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.17: document changes to the language for Go 1.17 #46020

Closed
gopherbot opened this issue May 6, 2021 · 8 comments
Closed

doc/go1.17: document changes to the language for Go 1.17 #46020

gopherbot opened this issue May 6, 2021 · 8 comments
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@gopherbot
Copy link

gopherbot commented May 6, 2021

As of filing this issue, the Go 1.17 draft release notes contained the following HTML:

Changes to the language

TODO: https://golang.org/cl/216424: allow conversion from slice to array ptr

TODO: complete this section


This TODO needs to be resolved by July 1 so that we can have complete release notes for Beta 1.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.17:" prefix and include "For doc: write Go 1.17 release notes #44513. Fixes doc/go1.17: document changes to the language for Go 1.17 #46020." in the body.
@gopherbot gopherbot added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 6, 2021
@gopherbot gopherbot added this to the Go1.17 milestone May 6, 2021
@dmitshur
Copy link
Contributor

dmitshur commented May 6, 2021

"spec" isn't a Go package. This TODO should be moved to the https://tip.golang.org/doc/go1.17#language section. I can help with that.

@dmitshur dmitshur changed the title doc/go1.17: document spec changes for Go 1.17 doc/go1.17: document changes to the language for Go 1.17 May 6, 2021
@dmitshur
Copy link
Contributor

dmitshur commented May 6, 2021

@griesemer In addition to "spec: allow conversion from slice to array ptr" (CL 216424), are there more change to the language for Go 1.17? I see the go_spec.html file has a number of clarifications, and "spec: add unsafe.Add and unsafe.Slice" (CL 312212) stands out as possible candidate for highlighting. (CC @mdempsky)

@gopherbot
Copy link
Author

Change https://golang.org/cl/317829 mentions this issue: doc/go1.17: move language specification TODO to the right place

@griesemer
Copy link
Contributor

The new conversion and the new unsafe functions are the only changes worth highlighting per git history of changes to the spec. The other changes are minor.

gopherbot pushed a commit that referenced this issue May 7, 2021
It was misplaced by the relnote tool.

Also add a TODO for CL 312212, per discussion in golang.org/issue/46020.

For #44513.
For #46020.

Change-Id: I8d766df969f85c351ead18df3e45adb6fb27b7a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/317829
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Jun 2, 2021

@josharian Are you able to send a CL to document the "allow conversion from slice to array ptr" language change in the Go 1.17 release notes, and resolve the TODO at https://tip.golang.org/doc/go1.17#language?

@mdempsky Are you able to send a CL to document the "add unsafe.Add and unsafe.Slice" language change?

You can find past examples of language changes at https://golang.org/doc/go1.14#language, https://golang.org/doc/go1.10#language, and https://golang.org/doc/go1.13#language to get a sense of how much detail is helpful to include. Thank you if you're able to help with this.

@gopherbot
Copy link
Author

Change https://golang.org/cl/325549 mentions this issue: doc/go1.17: document slice to array pointer conversion

@gopherbot
Copy link
Author

Change https://golang.org/cl/325870 mentions this issue: doc: document Go 1.17 language changes

@gopherbot
Copy link
Author

Change https://golang.org/cl/326149 mentions this issue: doc/go1.17: mention new possibility of type conversion panicking

gopherbot pushed a commit that referenced this issue Jun 8, 2021
For #44513
For #46020

Change-Id: I07c7a4268465c536d1866cc6bb1fad76b2b88b15
Reviewed-on: https://go-review.googlesource.com/c/go/+/326149
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@golang golang locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants