Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/go1.17: document crypto/rsa changes for Go 1.17 #46006

Closed
gopherbot opened this issue May 6, 2021 · 2 comments
Closed

doc/go1.17: document crypto/rsa changes for Go 1.17 #46006

gopherbot opened this issue May 6, 2021 · 2 comments
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.17

Comments

@gopherbot
Copy link

As of filing this issue, the Go 1.17 draft release notes contained the following HTML:

crypto/rsa

TODO: https://golang.org/cl/302230: fix salt length calculation with PSSSaltLengthAuto

This TODO needs to be resolved by July 1 so that we can have complete release notes for Beta 1.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.17:" prefix and include "For doc: write Go 1.17 release notes #44513. Fixes doc/go1.17: document crypto/rsa changes for Go 1.17 #46006." in the body.
@gopherbot gopherbot added Documentation help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 6, 2021
@gopherbot gopherbot added this to the Go1.17 milestone May 6, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Jun 2, 2021

Hi @hkishn, are you able to help suggest an entry for the Go 1.17 release notes to resolve this TODO and document the change made in CL 302230?

You can either make a suggestion on this issue, or send a CL that edits doc/go1.17.html directly if that's easier. Thanks if you can help with this!

@FiloSottile
Copy link
Contributor

This is a bug fix that resolves an error, not introduce a new one, so it's unlikely to break anyone, and very few applications need these key sizes, so I don't think we need to surface it in the release notes.

@golang golang locked and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@FiloSottile @dmitshur @gopherbot