Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator, x/build/livelog: annotate truncated logs #45972

Closed
prattmic opened this issue May 5, 2021 · 1 comment
Closed

x/build/cmd/coordinator, x/build/livelog: annotate truncated logs #45972

prattmic opened this issue May 5, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@prattmic
Copy link
Member

prattmic commented May 5, 2021

Builder logs have a 2MB size limit. Once that limit is reached, all remaining output is silently truncated. For someone reading the log, this truncation can be difficult or impossible to detect.

For example, in https://storage.googleapis.com/go-build-log/9041f75f/linux-amd64-longtest_50b82ee1.log, the truncation can be inferred because the last goroutine stack trace is missing the filename/line number line following sync/atomic_test.TestValueSwapConcurrent.func1(). Alternatively, note that the file is exactly 2MB. If the truncation occurred between two different goroutine stack traces, it would be impossible to tell for sure.

We could make this much more clear by adding a "log truncated" message to the end of the logs.

cc @mknyszek @bcmills

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 5, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 5, 2021
@dmitshur dmitshur changed the title x/build: annotate truncated logs x/build/cmd/coordinator, x/build/livelog: annotate truncated logs May 5, 2021
@gopherbot
Copy link

Change https://golang.org/cl/317209 mentions this issue: livelog: annotate log truncation

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label May 5, 2021
@golang golang locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants