Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: #45950

Closed
RobHumphris opened this issue May 4, 2021 · 5 comments
Closed

x/net/http2: #45950

RobHumphris opened this issue May 4, 2021 · 5 comments
Labels
FrozenDueToAge

Comments

@RobHumphris
Copy link

What version of Go are you using (go version)?

go version go1.14 linux/amd64

Does this issue reproduce with the latest release?

Caused by the latest release. golang.org/x/net v0.0.0-20210504132125-bbd867fde50d

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/rob/.cache/go-build"
GOENV="/home/rob/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="github.com/8power,github.com/RobHumphris"
GONOSUMDB="github.com/8power,github.com/RobHumphris"
GOOS="linux"
GOPATH="/mnt/c/Users/User/go"
GOPRIVATE="github.com/8power,github.com/RobHumphris"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/mnt/c/Users/User/go/src/data-reprocessing/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build056882833=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Updated my dependencies in order to bring in a new version of a module used elsewhere in my project.

What did you expect to see?

go get to get the modules as per usual.

What did you see instead?

# golang.org/x/net/http2
../../pkg/mod/golang.org/x/net@v0.0.0-20210504132125-bbd867fde50d/http2/transport.go:598:14: undefined: tls.Dialer
note: module requires Go 1.17

I need to stick with the version of Go that I have as I am deploying a lot of Go based Google Cloud Functions - and thats pegged at v1.13.
@ALTree
Copy link
Member

ALTree commented May 4, 2021

Dup of #45946.

@ALTree ALTree closed this as completed May 4, 2021
@gopherbot
Copy link

Change https://golang.org/cl/317069 mentions this issue: crypto/tls: don't use tls.Dialer on pre-Go1.15 systems

gopherbot pushed a commit to golang/net that referenced this issue May 5, 2021
@ianlancetaylor
crypto/tls: don't use tls.Dialer on pre-Go1.15 systems
0714010 
We have received many reports of build failures using Go 1.14,
enough to make it worth supporting that release even though it
is out of our support window.

For golang/go#45942
For golang/go#45943
For golang/go#45946
For golang/go#45950
For golang/go#45968

Change-Id: I9d6b1762ae622b3e9a5de5b1967264387166b1c7
Reviewed-on: https://go-review.googlesource.com/c/net/+/317069
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@ianlancetaylor
Copy link
Contributor

Since this came up five times in 24 hours, I went ahead and patches golang.org/x/net so that it will work with versions of Go before 1.15. That should fix this problem. I still strongly encourage everyone to upgrade to a supported version of Go, and I do not promise that this will not break again in the future.

@RobHumphris
Copy link
Author

Since this came up five times in 24 hours, I went ahead and patches golang.org/x/net so that it will work with versions of Go before 1.15. That should fix this problem. I still strongly encourage everyone to upgrade to a supported version of Go, and I do not promise that this will not break again in the future.

Thank-you for this, I would love to upgrade but have my code in 14 different Google Cloud Functions - which is stuck at version 1.13 so I cannot upgrade until Google do.

@rsc
Copy link
Contributor

rsc commented May 7, 2021 •
edited

FWIW we are aware of GCE and GCF not yet supporting Go 1.16. I am hopeful (but can't promise) that they will by mid-summer. Apologies for the slow rollout there.

@coopergillan coopergillan mentioned this issue May 21, 2021
Closed
coopergillan added a commit to coopergillan/terraform-provider-redshift that referenced this issue May 21, 2021
@coopergillan
GH-28 - Drop support for go 1.12
9cd32cf 
What

Drop support for Go 1.12

Why

The golang.org/x/net/http2 dependency does not support older versions of
Go: golang/go#45950

Additionally, according to the Go website, only the latest two versions
of Go are officially supported:

https://golang.org/doc/devel/release.html#policy
@coopergillan coopergillan mentioned this issue May 21, 2021
Closed
@KyleJu KyleJu mentioned this issue Mar 7, 2022
Closed
@golang golang locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rsc @RobHumphris @ianlancetaylor @ALTree @gopherbot