Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net: undefined: tls.Dialer note: module requires Go 1.17 #45942

Closed
artemidas opened this issue May 4, 2021 · 6 comments
Closed

x/net: undefined: tls.Dialer note: module requires Go 1.17 #45942

artemidas opened this issue May 4, 2021 · 6 comments

Comments

@artemidas
Copy link

What version of Go are you using (go version)?

I'm using golang docker image on CircleCI golang:1.14-alpine3.12

Does this issue reproduce with the latest release?

Yes, like 1 hour after the last changes were pushed.

What did you do?

$ go vet -structtag=false -unmarshal -assign -atomic -unsafeptr -unusedresult ./...

Getting error:

# golang.org/x/net/http2
/go/pkg/mod/golang.org/x/net@v0.0.0-20210504132125-bbd867fde50d/http2/transport.go:598:14: undefined: tls.Dialer
note: module requires Go 1.17

Exited with code exit status 2

What did you expect to see?

CircleCI received exit code 0

What did you see instead?

CircleCI received exit code 2
@gopherbot gopherbot added this to the Unreleased milestone May 4, 2021
@ianlancetaylor
Copy link
Contributor

Our policy with repos like golang.org/x/net is that they only have to support the last two Go releases. Today that is the 1.15 and 1.16 releases. You are using 1.14. tls.Dialer was added in 1.15. In order to build tip x/net, you will need to update your Go installation.

@gopherbot
Copy link

Change https://golang.org/cl/317069 mentions this issue: crypto/tls: don't use tls.Dialer on pre-Go1.15 systems

gopherbot pushed a commit to golang/net that referenced this issue May 5, 2021
We have received many reports of build failures using Go 1.14,
enough to make it worth supporting that release even though it
is out of our support window.

For golang/go#45942
For golang/go#45943
For golang/go#45946
For golang/go#45950
For golang/go#45968

Change-Id: I9d6b1762ae622b3e9a5de5b1967264387166b1c7
Reviewed-on: https://go-review.googlesource.com/c/net/+/317069
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@ianlancetaylor
Copy link
Contributor

Since this came up five times in 24 hours, I went ahead and patches golang.org/x/net so that it will work with versions of Go before 1.15. That should fix this problem. I still strongly encourage everyone to upgrade to a supported version of Go, and I do not promise that this will not break again in the future.

@wang51089
Copy link

it is not an easy job for me to push the company`s k8s team to update go installation. So which version of golang.org/x/net is compatible with go 1.15 please

@ianlancetaylor
Copy link
Contributor

@wang51089 You'll probably get a better answer on a forum. See https://go.dev/wiki/Questions. As far as I know git revision 0714010a04edd230e18075cd951dd826f04b1e11 works with 1.15. But note that 1.15 is no longer supported.

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
We have received many reports of build failures using Go 1.14,
enough to make it worth supporting that release even though it
is out of our support window.

For golang/go#45942
For golang/go#45943
For golang/go#45946
For golang/go#45950
For golang/go#45968

Change-Id: I9d6b1762ae622b3e9a5de5b1967264387166b1c7
Reviewed-on: https://go-review.googlesource.com/c/net/+/317069
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@vediyappan-villali
Copy link

I am also getting the similar error. Even I am using go version 1.17. Is this issue fixed?

golang.org/x/net/http2

../../../../pkg/mod/golang.org/x/net@v0.0.0-20211112202133-69e39bad7dc2/http2/transport.go:417:45: undefined: os.ErrDeadlineExceeded
note: module requires Go 1.17

vediyappan@LX-9N9H9R2:~/work/yoctoproject/build$ go version
go version go1.17.8 linux/amd64

@golang golang locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants