Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/cmd/gorelease: tests are passing regardless of content #45892

Closed
jeanbza opened this issue Apr 30, 2021 · 1 comment
Closed

x/exp/cmd/gorelease: tests are passing regardless of content #45892

jeanbza opened this issue Apr 30, 2021 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@jeanbza
Copy link
Member

jeanbza commented Apr 30, 2021

deklerk at deklerk-macbookpro in ~/workspace/exp/cmd/gorelease on master*
$ git diff
diff --git a/cmd/gorelease/testdata/basic/v0_incompatible_verify.test b/cmd/gorelease/testdata/basic/v0_incompatible_verify.test
index c6742d3..5386837 100644
--- a/cmd/gorelease/testdata/basic/v0_incompatible_verify.test
+++ b/cmd/gorelease/testdata/basic/v0_incompatible_verify.test
@@ -9,7 +9,7 @@ example.com/basic/a
 Incompatible changes:
 - A2: removed

-example.com/basic/b
+asdasdsdexample.com/basic/b
 -------------------
 Incompatible changes:
 - package removed
deklerk at deklerk-macbookpro in ~/workspace/exp/cmd/gorelease on master*
$ go test .
ok  	golang.org/x/exp/cmd/gorelease	6.428s

I suspect this is somehow caused by https://go-review.googlesource.com/c/exp/+/288032, which changed a lot of the test framework. Will investigate further this weekend.

@gopherbot gopherbot added this to the Unreleased milestone Apr 30, 2021
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 30, 2021
@gopherbot
Copy link

Change https://golang.org/cl/318029 mentions this issue: cmd/gorelease: fix test runner, and implementation of existing versions check

@golang golang locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants