Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: unexpected trampoline when cross-compiling to ppc64le [1.16 backport] #45832

Closed
gopherbot opened this issue Apr 28, 2021 · 3 comments
Closed

cmd/link: unexpected trampoline when cross-compiling to ppc64le [1.16 backport] #45832

gopherbot opened this issue Apr 28, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.5

Comments

@gopherbot
Copy link

@pmur requested issue #45564 to be considered for backport to the next 1.16 minor release.

@gopherbot please consider a backport to 1.16. This seems to a be a regression from go 1.16.1 to 1.16.2.

I don't think a backport to earlier versions is necessary since the issue likely affects all 1.15 releases. It might be possible to workaround by not disabling cgo, or using external linking.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 28, 2021
@gopherbot gopherbot mentioned this issue Apr 28, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.4 milestone Apr 28, 2021
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Apr 29, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 29, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/316329 mentions this issue: [release-branch.go.16] cmd/link: disable plugin support if cgo is disabled

@heschi heschi modified the milestones: Go1.16.4, Go1.16.5 May 6, 2021
@gopherbot
Copy link
Author

Closed by merging c7248a0 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue May 20, 2021
@pmur @dmitshur
[release-branch.go1.16] cmd/link: disable plugin support if cgo is di…
c7248a0 
…sabled

Functional plugin support requires cgo to be enabled. Disable
it if the environment has disabled cgo.

This prevents unexpected linker failures when linking large
binaries with cgo disabled which use the plugin package.

Fixes #45832

Change-Id: Ib71f0e089f7373b7b3e3cd53da3612291e7bc473
Reviewed-on: https://go-review.googlesource.com/c/go/+/314449
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
(cherry picked from commit 983dea9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/316329
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.5
Development

No branches or pull requests
3 participants
@toothrot @gopherbot @heschi