Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: internal/poll.TestSplicePipePool fails on 32-bit platforms after sync.Pool CL 303949 #45782

Closed
cherrymui opened this issue Apr 26, 2021 · 3 comments
Closed

sync: internal/poll.TestSplicePipePool fails on 32-bit platforms after sync.Pool CL 303949 #45782

cherrymui opened this issue Apr 26, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.17

Comments

@cherrymui
Copy link
Member

After CL 303949 , there are a few failures for internal/poll.TestSplicePipePool fails on 32-bit platforms, e.g.

https://build.golang.org/log/6063d1764ac5d5c3644528362f002fb0a8a685d6 386
https://build.golang.org/log/de4fd7cd548eb95d0c76efc7d72513bdecf389d4 ARM
https://build.golang.org/log/19f144a0780b4f29d1533079c9141022de5d5672 MIPS

And internal/poll.Splice does use sync.Pool. So this CL is probably related.

@dr2chase @kels-ng
@cherrymui cherrymui added this to the Go1.17 milestone Apr 26, 2021
@cherrymui cherrymui added release-blocker NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 26, 2021
@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2021

See previously #45059 (CC @panjf2000 @ianlancetaylor @bradfitz).

@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2021

This also seems to be affecting some TryBot platforms (such as linux-arm-aws):
https://storage.googleapis.com/go-build-log/ea802e88/linux-arm-aws_4aeefd09.log

@bcmills bcmills added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Apr 26, 2021
@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2021

Fixed by revert in CL 313630.

@bcmills bcmills closed this as completed Apr 26, 2021
This was referenced Aug 30, 2021
Closed
Closed
@golang golang locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @cherrymui