Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: TestGuru/describe failing on unsafe.{Add,Slice} #45778

Closed
bcmills opened this issue Apr 26, 2021 · 5 comments
Closed

x/tools: TestGuru/describe failing on unsafe.{Add,Slice} #45778

bcmills opened this issue Apr 26, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2021

TestGuru/describe seems to be assuming that the unsafe package doesn't acquire new identifiers, which causes it to fail on the new identifiers added for #19367 and #40481.

--- FAIL: TestGuru (0.00s)
    --- FAIL: TestGuru/describe (1.93s)
        guru_test.go:307: Guru tests for testdata/src/describe/main.go failed: exit status 1.
            --- testdata/src/describe/main.golden	2021-04-22 17:05:18.000000000 +0000
            +++ /workdir/tmp/main.got3261975656	2021-04-23 01:17:04.938640486 +0000
            @@ -22,10 +22,12 @@
             
             -------- @describe unsafe --------
             import of package "unsafe"
            +	builtin Add     
             	builtin Alignof 
             	builtin Offsetof
             	type  Pointer  unsafe.Pointer
             	builtin Sizeof  
            +	builtin Slice   
             
             -------- @describe type-ref-builtin --------
             reference to built-in type float64
            
FAIL
FAIL	golang.org/x/tools/cmd/guru	82.201s

2021-04-26T15:43:18-7c93484/linux-386-longtest
2021-04-26T15:43:18-7c93484/linux-amd64-longtest
2021-04-26T15:26:58-716a04c/linux-386-longtest
2021-04-26T15:26:58-716a04c/linux-amd64-longtest
2021-04-23T21:15:18-f74a669/linux-386-longtest
2021-04-23T21:15:18-f74a669/linux-amd64-longtest
2021-04-23T19:11:18-e435455/linux-386-longtest
2021-04-23T19:11:18-e435455/linux-amd64-longtest
2021-04-23T17:35:25-f7e8e24/linux-386-longtest
2021-04-23T17:35:25-f7e8e24/linux-amd64-longtest
2021-04-23T16:19:37-a8e7c0c/linux-386-longtest
2021-04-23T16:19:37-a8e7c0c/linux-amd64-longtest
2021-04-22T17:05:18-f946a15/linux-386-longtest
2021-04-22T17:05:18-f946a15/linux-amd64-longtest

See previously #44596. Per my comment on the fix for that issue, I still wonder if we should just delete that case from TestGuru.

CC @mdempsky @findleyr @griesemer
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 26, 2021
@gopherbot gopherbot added this to the Unreleased milestone Apr 26, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Apr 26, 2021

Marking as release-blocker for 1.17 via #11811.

@bcmills bcmills added release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 26, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.17 Apr 26, 2021
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 26, 2021
@findleyr
Copy link
Contributor

Thanks, I have https://golang.org/cl/313251 out to fix.

@gopherbot
Copy link

Change https://golang.org/cl/313251 mentions this issue: cmd/guru: remove test assertions involving unsafe to fix the build

@findleyr
Copy link
Contributor

Hmm, longtest builders are still failing due to changing position information. I'm sure I tested my fix locally, but perhaps I changed a line number afterward... hmm.

In any case, fix #2 incoming.

@findleyr findleyr reopened this Apr 26, 2021
@gopherbot
Copy link

Change https://golang.org/cl/313669 mentions this issue: cmd/guru: update referrers-json testdata to reflect new line numbering

@golang golang locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr