Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/signal: TestSignalTrace failures on linux-ppc64* with "timeout … waiting for hangup" #45773

Closed
bcmills opened this issue Apr 26, 2021 · 5 comments
Closed

os/signal: TestSignalTrace failures on linux-ppc64* with "timeout … waiting for hangup" #45773

bcmills opened this issue Apr 26, 2021 · 5 comments
Labels
arch-ppc64x FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2021

2021-04-23T21:48:37-9cc3469/linux-ppc64le-buildlet
2021-04-23T21:43:10-bf92160/linux-ppc64-buildlet
2021-04-23T21:43:08-a25d1d4/linux-ppc64-buildlet
2021-04-22T22:01:47-7405968/linux-ppc64-buildlet
2021-04-22T21:23:59-f7afdfd/linux-ppc64-buildlet
2021-04-22T21:23:59-f7afdfd/linux-ppc64le-buildlet
2021-04-22T04:04:47-ece5935/linux-ppc64-buildlet
2021-04-21T23:21:55-7bedd47/linux-ppc64-buildlet
2021-04-21T21:25:26-7e97e4e/linux-ppc64-buildlet

--- FAIL: TestSignalTrace (0.43s)
    signal_test.go:880: timeout after 200ms waiting for hangup
FAIL
FAIL	os/signal	6.243s

CC @ianlancetaylor @laboger @ceseo
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-ppc64x labels Apr 26, 2021
@bcmills bcmills added this to the Backlog milestone Apr 26, 2021
@laboger
Copy link
Contributor

laboger commented Apr 26, 2021

Interesting that these started after https://go-review.googlesource.com/c/go/+/305149/ was merged.

FYI replace @pmur for @ceseo for notification of ppc64x issues. Thanks.

@pmur
Copy link
Contributor

pmur commented Apr 26, 2021

I tested this on an older POWER8/Ubuntu 16/ppc64le machine. I see this failure before and after this patch (I backported the test with it). Notably, the failing test was added in this commit. This test seems to hiccup on the failing machine, taking 6-7x or longer on some runs.

I can't reproduce on most other P8/P9 machines though.

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Apr 28, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Apr 28, 2021

Marking as release-blocker for Go 1.17 because this test is new as of 1.17.

(CC @golang/release)

@bcmills
Copy link
Contributor Author

bcmills commented Apr 28, 2021

2021-04-28T12:51:42-f68878f/linux-ppc64-buildlet
2021-04-27T21:16:55-30002e6/linux-ppc64le-buildlet
2021-04-27T19:18:02-8ab7064/linux-ppc64-buildlet
2021-04-27T17:03:53-074a49b/linux-ppc64-buildlet
2021-04-27T02:39:52-434e12f/linux-ppc64le-buildlet
2021-04-26T21:35:26-be28caf/linux-ppc64-buildlet
2021-04-26T21:35:26-be28caf/linux-ppc64le-buildlet

@gopherbot
Copy link

Change https://golang.org/cl/315049 mentions this issue: os/signal: increase test timeouts on ppc64*/linux

@bcmills bcmills mentioned this issue Jun 14, 2021
Closed
@golang golang locked and limited conversation to collaborators May 4, 2022
@dmitshur dmitshur modified the milestones: Backlog, Go1.17 Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-ppc64x FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
5 participants
@dmitshur @bcmills @gopherbot @laboger @pmur