Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: complains about _content dir in x/website #45734

Closed
seankhliao opened this issue Apr 23, 2021 · 2 comments
Closed

x/review/git-codereview: complains about _content dir in x/website #45734

seankhliao opened this issue Apr 23, 2021 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@seankhliao
Copy link
Member

messageRE in git-codereview is used to validate the commit message title, but this doesn't play nice with the new _content/ directory in x/website.

var messageRE = regexp.MustCompile(`^(\[[a-zA-Z0-9.-]+\] )?[a-zA-Z0-9-/,. ]+: `)
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2021
@cherrymui
Copy link
Member

cc @kevinburke @rsc

@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 26, 2021
@gopherbot
Copy link

Change https://go.dev/cl/496775 mentions this issue: git-codereview: allow _content to not warn

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @seankhliao @cherrymui