Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: update to FreeBSD-[amd64|386]-11_4 builder for 1.17 Beta #45727

Closed
cagedmantis opened this issue Apr 23, 2021 · 3 comments
Closed

x/build/cmd/release: update to FreeBSD-[amd64|386]-11_4 builder for 1.17 Beta #45727

cagedmantis opened this issue Apr 23, 2021 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD release-blocker
Projects
Go Release Team
Milestone
Go1.17

Comments

@cagedmantis
Copy link
Contributor

The cmd/release command is currently configured to use the freebsd-{amd64,386}-11_2 builders for the freebsd release targets.

FreeBSD 11.2 will not be supported by the time Go 1.17 is released. We should use FreeBSD 11.4 builders during the release.

/cc @golang/release
@cagedmantis cagedmantis added OS-FreeBSD Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker labels Apr 23, 2021
@cagedmantis cagedmantis added this to the Go1.17 milestone Apr 23, 2021
@gopherbot
Copy link

Change https://golang.org/cl/313070 mentions this issue: dashboard: make FreeBSD 11.4 and 12.2 builders the default

@dmitshur
Copy link
Contributor

Using the latest "patch" release of the oldest "major" release of FreeBSD that we support for issuing Go 1.17 releases seems consistent with what we've done before, and SGTM.

gopherbot pushed a commit to golang/build that referenced this issue Apr 26, 2021
@cagedmantis
dashboard: make FreeBSD 11.4 and 12.2 builders the default
2ecf424 
With this change:
- The default FreeBSD builders used on master are 11.4 and 12.2.
- The FreeBSD 12.0 builders have been removed.
- The FreeBSD 11.2 builders have been set to run on at most Go 1.16.
  They will continue to be used for Go 1.16.x and 1.15.x minor releases.
- The freebsd-amd64-race builder has been updated to use the FreeBSD
  12.2 host.
- The slowbot aliases for FreeBSD have been updated to use 12.2.

Fixes golang/go#44431
Update golang/go#45727
Update golang/go#40561

Change-Id: Ib558fca65c2de1916b4633711d3e320c390bd2b2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313070
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@cagedmantis cagedmantis self-assigned this Apr 28, 2021
@toothrot toothrot added this to In Progress in Go Release Team Apr 29, 2021
@cagedmantis cagedmantis mentioned this issue Apr 30, 2021
Open
@gopherbot
Copy link

Change https://golang.org/cl/315889 mentions this issue: cmd/release: start using the FreeBSD 11.4 builder for Go 1.17

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Apr 30, 2021
Go Release Team automation moved this from In Progress to Done May 3, 2021
@ianlancetaylor ianlancetaylor mentioned this issue Feb 24, 2022
Closed
@golang golang locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD release-blocker
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot