Skip to content

x/website: incorrect quoting in example snippet on Go Modules Reference #45691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daniken opened this issue Apr 22, 2021 · 1 comment
Closed

x/website: incorrect quoting in example snippet on Go Modules Reference #45691

daniken opened this issue Apr 22, 2021 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@daniken
Copy link

daniken commented Apr 22, 2021

What version of Go are you using (go version)?

Not applicable.

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Not applicable.

What did you do?

Read through documentation and saw that following example snippet shown under this paragraph is incorrect:

[url "git@github.com:']
    insteadOf = https://github.com/

What did you expect to see?

Either double quotes or single quotes.

What did you see instead?

Both.
@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2021
@seankhliao seankhliao added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. labels Apr 22, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/313189 mentions this issue: _content/doc: fix gitconfig typo

@dmitshur dmitshur changed the title x/website:incorrect-example-snippet-under-mod-private-module-repo-auth x/website: incorrect quoting in example snippet on Go Modules Reference Apr 23, 2021
@golang golang locked and limited conversation to collaborators Apr 30, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
_content/doc: fix gitconfig typo

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
5c4c3ae 
Fixes golang/go#45691

Change-Id: I6ad64a06853d153f90636583abede168573b89b6
Reviewed-on: https://go-review.googlesource.com/c/website/+/313189
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @daniken