Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: Invalid PPC64 rotate mask [1.16 backport] #45636

Closed
gopherbot opened this issue Apr 19, 2021 · 7 comments
Closed

cmd/compile: internal compiler error: Invalid PPC64 rotate mask [1.16 backport] #45636

gopherbot opened this issue Apr 19, 2021 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.4

Comments

@gopherbot
Copy link

@pmur requested issue #45589 to be considered for backport to the next 1.16 minor release.

@gopherbot backport to 1.16 please
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 19, 2021
@gopherbot gopherbot mentioned this issue Apr 19, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.4 milestone Apr 19, 2021
@pmur
Copy link
Contributor

pmur commented Apr 19, 2021

The original issue was opened against the 1.16 when the merging support was added. It appears to have prevented somebody from compiling non-intuitive code (That is, a 0-length shift feeding an andi).

@gopherbot
Copy link
Author

Change https://golang.org/cl/311378 mentions this issue: [release-branch.go1.16] cmd/compile: fix ANDI/SRWI merge on ppc64

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Apr 22, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 22, 2021
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

@toothrot
Copy link
Contributor

@pmur @ALTree Does this also impact 1.15? If so, we need to open a backport for 1.15 as well.

@pmur
Copy link
Contributor

pmur commented Apr 22, 2021

@toothrot Nope. 1.16 only.

@cagedmantis
Copy link
Contributor

Thank you for this work @pmur

@gopherbot
Copy link
Author

Closed by merging 7e70979 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue May 4, 2021
@pmur @cagedmantis
[release-branch.go1.16] cmd/compile: fix ANDI/SRWI merge on ppc64
7e70979 
The shift amount should be masked to avoid rotation values
beyond the numer of bits. In this case, if the shift amount
is 0, it should rotate 0, not 32.

Fixes #45636

Change-Id: I1e764497a39d0ec128e29af42352b70c70b2ecc5
Reviewed-on: https://go-review.googlesource.com/c/go/+/310569
Run-TryBot: Paul Murphy <murp@ibm.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Carlos Eduardo Seo <carlos.seo@linaro.org>
Trust: Carlos Eduardo Seo <carlos.seo@linaro.org>
(cherry picked from commit c8fb0ec)
Reviewed-on: https://go-review.googlesource.com/c/go/+/311378
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
@golang golang locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.4
Development

No branches or pull requests
4 participants
@toothrot @cagedmantis @gopherbot @pmur