Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: incorrect synopsis for index/suffixarray #45614

Closed
afq984 opened this issue Apr 18, 2021 · 3 comments
Closed

x/website: incorrect synopsis for index/suffixarray #45614

afq984 opened this issue Apr 18, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@afq984
Copy link

afq984 commented Apr 18, 2021

What did you do?

Visit https://golang.org/pkg/index/ and https://golang.org/pkg

What did you expect to see?

image

What did you see instead?

image

Git bisect says https://go-review.googlesource.com/c/website/+/296378
@gopherbot gopherbot added this to the Unreleased milestone Apr 18, 2021
@gopherbot
Copy link

Change https://golang.org/cl/311089 mentions this issue: internal/pkgdoc: fix synopsis pkg name == dir name matching

@smasher164 smasher164 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 18, 2021
@seankhliao
Copy link
Member

duplicate of #45042 ?

@afq984
Copy link
Author

afq984 commented Apr 18, 2021 •
edited

@seankhliao oops, yes, they look like the same problem

@afq984 afq984 closed this as completed Apr 18, 2021
gopherbot pushed a commit to golang/website that referenced this issue Apr 26, 2021
@afq984 @dmitshur
internal/pkgdoc: fix synopsis pkg name == dir name matching
1eaa20f 
file.Name.Name should match the directory name not the filename.

In CL 296378, newDirTree's name parameter was removed and synopsis
matched against the filename of the source code, e.g. "*.go".

Fixes golang/go#45042
Fixes golang/go#45614

Change-Id: Ifa4c8a70429e277efb1f9f726de9249509cbcee0
Reviewed-on: https://go-review.googlesource.com/c/website/+/311089
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Apr 18, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
internal/pkgdoc: fix synopsis pkg name == dir name matching
2b5f968 
file.Name.Name should match the directory name not the filename.

In CL 296378, newDirTree's name parameter was removed and synopsis
matched against the filename of the source code, e.g. "*.go".

Fixes golang/go#45042
Fixes golang/go#45614

Change-Id: Ifa4c8a70429e277efb1f9f726de9249509cbcee0
Reviewed-on: https://go-review.googlesource.com/c/website/+/311089
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@afq984 @gopherbot @seankhliao @smasher164