Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dl: add go1.2.2, go1.3.3 and go1.4.3 #45608

Open
perillo opened this issue Apr 17, 2021 · 5 comments
Open

dl: add go1.2.2, go1.3.3 and go1.4.3 #45608

perillo opened this issue Apr 17, 2021 · 5 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unreleased

Comments

@perillo
Copy link
Contributor

perillo commented Apr 17, 2021

These versions don't have the SH256 checksum available, however the SHA1 checkum is listed on https://golang.org/dl, as an example https://golang.org/dl/#go1.4.3.

In order to support them, it is necessary to print a warning in case the SHA256 is not available, instead of terminating the program.
Here is an example of the warning from my CL (not yet submitted):

Warning: SHA256 Checksum not found: https://storage.googleapis.com/golang/go1.4.3.linux-amd64.tar.gz.sha256: 404 Not Found
The SHA1 Checksum can be found on https://golang.org/dl/#go1.4.3
@toothrot toothrot changed the title dl: add go1.2.2, go1.3.3 and go1.4.3 x/dl: add go1.2.2, go1.3.3 and go1.4.3 Apr 19, 2021
@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2021
@toothrot toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Apr 19, 2021
@toothrot
Copy link
Contributor

/cc @golang/release

@FiloSottile
Copy link
Contributor

We can and should just replace SHA1 hashes with SHA256 hashes for older releases, instead.

@perillo
Copy link
Contributor Author

perillo commented May 6, 2021

@FiloSottile, any news about adding SHA256 hashes for older releases?

@perillo perillo mentioned this issue May 6, 2021
Closed
@dmitshur
Copy link
Contributor

@perillo It's unlikely we'll have time for this while in the Go 1.17 freeze, but perhaps afterwards.

@dmitshur dmitshur changed the title x/dl: add go1.2.2, go1.3.3 and go1.4.3 dl: add go1.2.2, go1.3.3 and go1.4.3 May 21, 2021
@perillo
Copy link
Contributor Author

perillo commented May 22, 2021

@dmitshur, well, it is not really an important change. Thanks for the reply.

@vyneer vyneer mentioned this issue Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@toothrot @FiloSottile @dmitshur @perillo @gopherbot