Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: missing error for non-comparable switch expression in empty switch #45575

Closed
griesemer opened this issue Apr 14, 2021 · 2 comments
Closed

go/types: missing error for non-comparable switch expression in empty switch #45575

griesemer opened this issue Apr 14, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@griesemer
Copy link
Contributor

Missing go/types error for:

package p

func _() {
	var a struct{ _ func() }
	switch a {
	}
}

This has been fixed in types2. See #43200 for details.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 14, 2021
@griesemer griesemer added this to the Go1.17 milestone Apr 14, 2021
@findleyr
Copy link
Contributor

This was fixed in https://golang.org/cl/278813, which I just confirmed at tip with the example in this issue.

@griesemer where are you noticing the missing error?

@griesemer
Copy link
Contributor Author

Never mind - it turns out that I was running the test incorrectly for go/types.

@golang golang locked and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
3 participants
@griesemer @gopherbot @findleyr