Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: doc strings on struct fields do not display in Safari #45572

Closed
cpuguy83 opened this issue Apr 14, 2021 · 5 comments
Closed

x/pkgsite: doc strings on struct fields do not display in Safari #45572

cpuguy83 opened this issue Apr 14, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@cpuguy83
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/cpuguy83/dockercfg

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

Screenshot

image

Data is present just not showing:

image

What did you do?

Add a doc string to a struct field

e.g.

type Foo struct {
  // COMMENT HERE
  Foo string
}

What did you expect to see?

The comment should show in the doc site.

What did you see instead?

There is whitespace for the comment and the comment data is there, the actual comment does not show up, though.

This is the same on both pkg.go.dev and godoc.org
@gopherbot gopherbot added this to the Unreleased milestone Apr 14, 2021
@imjasonh
Copy link

imjasonh commented Apr 14, 2021 •
edited

FWIW I see the correct behavior using the same Safari version on a later macOS (and on latest Chrome for macOS):

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.3 Safari/605.1.15

Screen Shot 2021-04-14 at 4 49 16 PM

@julieqiu
Copy link
Member

I am also unable to reproduce this issue with the same user agent:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

image

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 14, 2021
@cpuguy83
Copy link
Author

Interesting...

I swear I saw this on iOS as well a little while back, but cannot repro it there anymore.
Knowing this I started messing with addons...
Turned off an ad blocker (1Blocker) and the problem went away.

@artyom
Copy link
Member

artyom commented Apr 15, 2021

Somewhat relevant: few days ago I almost opened an issue about http.Cookie type header not showing up on Safari (the <h2 id="Cookie">... node was not rendering at all), but once I loaded the page with content blockers disabled, it rendered fine. I used Wipr.

@julieqiu
Copy link
Member

Thanks all for investigating! Closing this issue since there isn't anything actionable on our end.

@golang golang locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@artyom @imjasonh @cpuguy83 @julieqiu @gopherbot