Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/execabs: replace ioutil.WriteFile with os.WriteFile in error messages #45532

Closed
perillo opened this issue Apr 12, 2021 · 8 comments
Closed

internal/execabs: replace ioutil.WriteFile with os.WriteFile in error messages #45532

perillo opened this issue Apr 12, 2021 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@perillo
Copy link
Contributor

perillo commented Apr 12, 2021

In execabs_test.go calls to ioutil.WriteFile have been replaced by os.WriteFile but the error messages have not been updated.
@gopherbot
Copy link

Change https://golang.org/cl/309350 mentions this issue: internal/execabs: replace ioutil.WriteFile with os.WriteFile

@ianlancetaylor
Copy link
Contributor

Thanks. If you're going to send a patch anyhow, there's no particular need to open an issue. You can just send the patch. Thanks again.

@perillo
Copy link
Contributor Author

perillo commented Apr 12, 2021

OK, thanks.

@mknyszek
Copy link
Contributor

Given that the issue exists, I'll simply leave this issue open and let it close with the CL.

@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 12, 2021
@mknyszek mknyszek added this to the Go1.17 milestone Apr 12, 2021
@perillo
Copy link
Contributor Author

perillo commented Apr 12, 2021

Should I use the special notation Closes #45532. I have noted that a few commits have this, but it is not documented in https://golang.org/doc/contribute.

Will Fixes #45532 also close this issue?

Thanks.

@ianlancetaylor
Copy link
Contributor

Writing "Fixes #45532" will close the issue.

See https://golang.org/wiki/CommitMessage.

@perillo
Copy link
Contributor Author

perillo commented Apr 12, 2021

Thanks for the references.

I noted that the Fixes line does not have the full stop character .. I have started to add it in recent changes since many commit messages have it...

@ianlancetaylor
Copy link
Contributor

The "Fixes" line should not have a full stop character. The cases where it is present are not the desired style. Thanks.

@golang golang locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@mknyszek @ianlancetaylor @perillo @gopherbot