Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: example test seems to have fd leak #4551

Closed
rsc opened this issue Dec 15, 2012 · 3 comments
Closed

testing: example test seems to have fd leak #4551

rsc opened this issue Dec 15, 2012 · 3 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@rsc
Copy link
Contributor

rsc commented Dec 15, 2012 

I ran an example test under strace -f to figure out a mysterious case of issue #4550, and
I observed that the fds are going up by 1 in each successive example test. Looks like
the read side of the pipe is never closed. Should be very easy.
@davecheney
Copy link
Contributor

Comment 1:

@rsc - do you think this is a new regression, possibly
https://code.google.com/p/go/source/detail?r=ee5afd4b14b72176c3e5bb83c804b2ed230e2c91,
or a pre existing issue ?

@davecheney
Copy link
Contributor

Comment 2:

@rsc - do you think this is a new regression, possibly
https://code.google.com/p/go/source/detail?r=ee5afd4b14b72176c3e5bb83c804b2ed230e2c91,
or a pre existing issue ?

@rsc
Copy link
Contributor Author

rsc commented Dec 22, 2012

Comment 3:

This issue was closed by revision 4b7c2df.

Status changed to Fixed.

@rsc rsc added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Dec 22, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
3 participants
@davecheney @rsc @gopherbot