Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: support build tags #45497

Closed
lazyhacker opened this issue Apr 10, 2021 · 2 comments
Closed

x/pkgsite: support build tags #45497

lazyhacker opened this issue Apr 10, 2021 · 2 comments
Labels
FrozenDueToAge pkgsite
Milestone
Unreleased

Comments

@lazyhacker
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/lazyhacker.dev/getgo

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

Screenshot

image

What did you do?

Created a go project.

What did you expect to see?

In the source code section there should be a main_gui.go. In the directories section it should have internal > guimain

These are recognized by go mod as the go.mod shows the dpendencies that it needs.

What did you see instead?

It is missing the main_gui.go source file and internal library guimain.
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2021
@seankhliao seankhliao changed the title x/pkgsite: Missing go source files. x/pkgsite: support build tags Apr 11, 2021
@seankhliao
Copy link
Member

related #37232

@jba
Copy link
Contributor

jba commented Apr 12, 2021

The main_gui.go file has a gui build tag, so we don't show it.

While we support a few common build tags for GOOS/GOARCH, it isn't feasible to support arbitrary tags. The nature of our backend/frontend split requires that the backend know all the build tags that will be available to the frontend. #37232 explains the problem in more detail.

@jba jba closed this as completed Apr 12, 2021
@phlogistonjohn phlogistonjohn mentioned this issue Nov 1, 2021
Open
@golang golang locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@lazyhacker @gopherbot @seankhliao @jba