Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gofmt: inconsistent indentation in var block #45491

Closed
charlesvdv opened this issue Apr 10, 2021 · 2 comments
Closed

cmd/gofmt: inconsistent indentation in var block #45491

charlesvdv opened this issue Apr 10, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@charlesvdv
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.16.2 linux/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/charles/.go/bin"
GOCACHE="/home/charles/.cache/go-build"
GOENV="/home/charles/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/charles/.go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/charles/.go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3438103609=/tmp/go-build -gno-record-gcc-switches"

What did you do?

See this go playground link

What did you expect to see?

package main

var (
	someLoooonnnnnnngName = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()

	short = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()
)

var yetAnotherLooooonnnnnnngName = NewBuilder().
	WithB(
		NewB().
			WithC(),
	).
	Build()

What did you see instead?

diff:

5c5
< 		WithB(
---
> 				WithB(

full file:

package main

var (
	someLoooonnnnnnngName = NewBuilder().
				WithB(                                            // <- Wrong indentation here
			NewB().
				WithC(),
		).
		Build()

	short = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()
)

var yetAnotherLooooonnnnnnngName = NewBuilder().
	WithB(
		NewB().
			WithC(),
	).
	Build()
@seankhliao
Copy link
Member

possibly duplicate of #41889 ?

@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 11, 2021
@ianlancetaylor
Copy link
Contributor

This behavior is intentional. See #644, #7335, #10392, #22852.

@golang golang locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianlancetaylor @gopherbot @seankhliao @charlesvdv