Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: remove tcw.im/ufc and tcw.im/ufc/redigo #45487

Closed
staugur opened this issue Apr 10, 2021 · 6 comments
Closed

x/pkgsite: remove tcw.im/ufc and tcw.im/ufc/redigo #45487

staugur opened this issue Apr 10, 2021 · 6 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite

Comments

@staugur
Copy link

staugur commented Apr 10, 2021

What is the URL of the page with the issue?

As per instructions at https://go.dev/about for removing a package: please remove
https://pkg.go.dev/tcw.im/ufc and https://pkg.go.dev/tcw.im/ufc/redigo

This is my toolkit, but the submodules always use the old version in "go get", so I request to delete them to see if it can be resolved.

Thank you.

@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2021
@jba jba self-assigned this Apr 10, 2021
@jba
Copy link
Contributor

jba commented Apr 10, 2021

If we remove tcw.im/ufc we'll remove everything under that (every path which has that as the prefix). Is that OK?

@staugur
Copy link
Author

staugur commented Apr 10, 2021

Of course!

@jba
Copy link
Contributor

jba commented Apr 10, 2021

Done.

@jba jba closed this as completed Apr 10, 2021
@staugur
Copy link
Author

staugur commented Apr 14, 2021

Sorry, reopen the issue here.

After deleting and requesting this package again, will pkg.go.dev no longer update the document?

I tried the about#Adding a package method, but https://pkg.go.dev/tcw.im/ufc is still 404.

Can this package regenerate documentation? Still need to change the name?

Thanks.

@jba
Copy link
Contributor

jba commented Apr 14, 2021

It's permanently removed. We can un-remove it if you want. Maybe it would help if you explain what your ultimate goal is. Usually people ask us to remove a package because they either don't want anyone to see it ever again, or because they have renamed it.

You mentioned something about submodules in your original post. Can you explain your problem in more detail?

@jba jba reopened this Apr 14, 2021
@staugur
Copy link
Author

staugur commented Apr 15, 2021

Due to the time difference, I just received a reply. Okay, let me briefly describe it.

Cause

tcw.im/ufc is the toolkit referenced by my personal project, there is no third-party dependency, and the warehouse address is mygithub/go-ufc.

In other projects, I used github.com/gomodule/redigo and simply packaged it.

I want to put it in the mygithub/go-ufc repository (located in the redigo subdirectory).

The module named tcw.im/ufc/redigo is not included in tcw.im/ufc. It is an independent module (but it depends on a version <A> of tcw.im/ufc).

Because it depends on gomodule/redigo, I don’t want to install gomodule/redigo for every project that imports tcw.im/ufc

Ready to work

I refer to golang/tools/gopls to set go.mod.

And tcw.im is a static blog generated with hugo, the /ufc and /ufc/redigo created index.html separately, including go-import and go-source meta, the content is:

<meta name="go-import" content="tcw.im/ufc git https://github.com/staugur/go-ufc">
<meta name="go-source" content="tcw.im/ufc https://github.com/staugur/go-ufc/ https://github.com/staugur/go-ufc/tree/master{/ dir} https://github.com/staugur/go-ufc/blob/master{/dir}/{file}#L{line}">

Finally, tcw.im/ufc/redigo releases version redigo/v<B>, and the preparations are completed.

The warehouse structure now looks like this:

.
├── go.mod # module tcw.im/ufc
├── main.go
└── redigo
    # module tcw.im/ufc/redigo, require gomodule/redigo & tcw.im/ufc
    # replace tcw.im/ufc => ../
    ├── go.mod
    ├── go.sum
    ├── redigo.go

Test

Unfortunately, it can’t be reproduced now. I created and deleted a lot of tags when I tested before, but I remember that the general error message is:

$ go get tcw.im/ufc/redigo@v<B>
go: downloading tcw.im/ufc v<B>
go: downloading tcw.im/ufc/redigo v<B>
go get: tcw.im/ufc/redigo@v<X??> updating to
	tcw.im/ufc/redigo@v<B>: parsing go.mod:
	module declares its path as: tcw.im/ufc
	        but was required as: tcw.im/ufc/redigo

In ~/go/pkg/mod/tcw.im/, ufc@v<B> and ufc/redigo@v<B> files are the same.

That is, the real files of ufc/redigo in the warehouse are not downloaded.

Installing tcw.im/ufc/redigo always downloads the wrong version of tcw.im/ufc,
as well as the wrong tcw.im/ufc/redigo source code.
This is why I delete the module in pkg.go.dev.

Concluding remarks

Now that tcw.im/ufc/redigo has removed the dependency on tcw.im/ufc,
it seems to work.

No need to restore, I can change my name.

Thanks!

@jba jba closed this as completed Apr 15, 2021
@hyangah hyangah added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants