Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "invalid pc-encoded table" throw caused by bad cgo traceback (expandFinalInlineFrames) #45480

Closed
prattmic opened this issue Apr 9, 2021 · 5 comments
Closed

runtime: "invalid pc-encoded table" throw caused by bad cgo traceback (expandFinalInlineFrames) #45480

prattmic opened this issue Apr 9, 2021 · 5 comments
Assignees
@prattmic
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@prattmic
Copy link
Member

prattmic commented Apr 9, 2021

This is a follow-up to #44971, where #44971 (comment) noted a missing case.

@gopherbot please open backport for 1.16 and 1.15. The only workaround is to change the C traceback engine, which isn't usually feasible. This is a follow-up CL for a previously missed case.
@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 9, 2021
@prattmic prattmic added this to the Go1.17 milestone Apr 9, 2021
@prattmic prattmic self-assigned this Apr 9, 2021
@gopherbot
Copy link

Change https://golang.org/cl/309109 mentions this issue: runtime: non-strict InlTreeIndex lookup in expandFinalInlineFrame

@prattmic
Copy link
Member Author

prattmic commented Apr 9, 2021

@gopherbot please open a backport for 1.16 and 1.15. The only workaround is to change the C traceback engine, which isn't usually feasible. This is a follow-up CL for a previously missed case.

This was referenced Apr 9, 2021
Closed
Closed
@gopherbot
Copy link

Backport issue(s) opened: #45481 (for 1.15), #45482 (for 1.16).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@dmitshur dmitshur mentioned this issue Apr 9, 2021
Open
@gopherbot
Copy link

Change https://golang.org/cl/309550 mentions this issue: [release-branch.go1.15] runtime: non-strict InlTreeIndex lookup in expandFinalInlineFrame

@gopherbot
Copy link

Change https://golang.org/cl/309551 mentions this issue: [release-branch.go1.16] runtime: non-strict InlTreeIndex lookup in expandFinalInlineFrame

gopherbot pushed a commit that referenced this issue May 4, 2021
@prattmic @cagedmantis
[release-branch.go1.16] runtime: non-strict InlTreeIndex lookup in ex…
ea0537f 
…pandFinalInlineFrame

This is a follow-up to golang.org/cl/301369, which made the same change
in Frames.Next. The same logic applies here: a profile stack may have
been truncated at an invalid PC provided by cgoTraceback.
expandFinalInlineFrame will then try to lookup the inline tree and
crash.

The same fix applies as well: upon encountering a bad PC, simply leave
it as-is and move on.

For #44971
For #45480
Fixes #45482

Change-Id: I2823c67a1f3425466b05384cc6d30f5fc8ee6ddc
Reviewed-on: https://go-review.googlesource.com/c/go/+/309109
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Trust: Michael Pratt <mpratt@google.com>
(cherry picked from commit aad13cb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/309551
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue May 4, 2021
@prattmic @cagedmantis
[release-branch.go1.15] runtime: non-strict InlTreeIndex lookup in ex…
c0a7ecf 
…pandFinalInlineFrame

This is a follow-up to golang.org/cl/301369, which made the same change
in Frames.Next. The same logic applies here: a profile stack may have
been truncated at an invalid PC provided by cgoTraceback.
expandFinalInlineFrame will then try to lookup the inline tree and
crash.

The same fix applies as well: upon encountering a bad PC, simply leave
it as-is and move on.

For #44971
For #45480
Fixes #45481

Change-Id: I2823c67a1f3425466b05384cc6d30f5fc8ee6ddc
Reviewed-on: https://go-review.googlesource.com/c/go/+/309109
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Trust: Michael Pratt <mpratt@google.com>
(cherry picked from commit aad13cb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/309550
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 12, 2022
@prattmic prattmic self-assigned this Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prattmic prattmic

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
2 participants
@prattmic @gopherbot