Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: ~ in front of package declaration does not show an error #45478

Closed
heschi opened this issue Apr 9, 2021 · 1 comment
Closed
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@heschi
Copy link
Contributor

heschi commented Apr 9, 2021

If I put a ~ in front of the package declaration of a file, gopls gets very slow, but doesn't report an error that the ~ is invalid syntax. I haven't investigated yet, but it feels like the packages.Load goes sideways and the file is removed from the package, causing lots of errors in other files about missing declarations. And then since the file isn't in a package, we don't diagnose it any more, perhaps.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 9, 2021
@gopherbot gopherbot added this to the Unreleased milestone Apr 9, 2021
@heschi heschi modified the milestones: Unreleased, gopls/unplanned Apr 9, 2021
@findleyr
Copy link
Contributor

This doesn't seem to be a problem anymore, perhaps because of recent fixes to metadata invalidation.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022
@golang golang locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants