x/build/cmd/gopherbot: doesn't skip issues that were transferred #45461
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
help wanted
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
dmitshur
added
help wanted
Builders
|
Change https://golang.org/cl/308789 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Apr 9, 2021
The maintner data model doesn't expose when an issue gets transferred from one repo to another (that's golang.org/issue/37370), so GopherBot currently doesn't skip transferred issues when processing them. There turns out to be many transferred issues in the vscode-go repo, causing gopherbot to take too many repetitive actions as reported in golang.org/issue/45461. Skip the task by default until this is handled better to avoid depleting the GitHub quota way too quickly. For golang/go#45461. Change-Id: I404c94b342f9a870f159d3cadef6cfa2a9979d2d Reviewed-on: https://go-review.googlesource.com/c/build/+/308789 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
|
Closing as duplicate of #40640. |
|
Change https://go.dev/cl/397234 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Apr 1, 2022
When synchronizing comments of an issue, getting a 404 (or 410) from GitHub REST API's list comments endpoint should happen if and only if the issue no longer exists. Use that as a safe opportunity to append a mutation to the log that updates the issue's NotExist field to true. Maintner doesn't yet have complete support for transferred issues, a feature that GitHub added after its initial design. It's been difficult to add it retroactively as described in go.dev/issue/37603. This change aims to make a small incremental change that we can feel confident about applying and watching closely, and doesn't try to implement a complete fix. It should help get maintner unstuck when trying to sync comments in an issue tracker that has a transferred issue, and incurs a minimal risk of writing bad mutations. This CL is based on past work in CL 161521 and CL 176638, but is smaller in scope intentionally. For golang/go#37370. For golang/go#40640. Updates golang/go#45461. Fixes golang/go#52017. Change-Id: I3702d3c7b2e412cf75809fdb722c0ee693c8600e Reviewed-on: https://go-review.googlesource.com/c/build/+/397234 Trust: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
GopherBot doesn't skip issues that were transferred from one GitHub repository to another when processing them. The "set vscode-go milestones" task recently added in CL 308350 is highly affected by this, because there are many issues in golang/vscode-go that were transferred to the main Go issue tracker.
This can be reproduced locally with
gopherbotin -dry-run mode:All of those issues were transferred and so they should be skipped in the task, but aren't, and GopherBot performs a GitHub API call to set the milestone in a loop without ever succeeding. This contributes to a significant increase of GitHub API rate limit quota usage (see related issues #28320 and #44406).
Since GopherBot uses maintner data to iterate over issues, issue #37370 is relevant.
To avoid depleting the GitHub quota way too quickly, we'll unfortunately need to disable the new "set vscode-go milestones" task until this is resolved.
CC @golang/release, @stamblerre, @hyangah.
The text was updated successfully, but these errors were encountered: