Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: case sensitivity messes up docs #45409

Closed
tonglil opened this issue Apr 6, 2021 · 6 comments
Closed

x/pkgsite: case sensitivity messes up docs #45409

tonglil opened this issue Apr 6, 2021 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@tonglil
Copy link

tonglil commented Apr 6, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/pagerduty/go-pagerduty
https://pkg.go.dev/github.com/PagerDuty/go-pagerduty

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:86.0) Gecko/20100101 Firefox/86.0

What did you expect to see?

The same page regardless of casing.
They both link to the same github org, just after casing was changed.

What did you see instead?

Two separate pages.

@gopherbot gopherbot added this to the Unreleased milestone Apr 6, 2021
@slrz
Copy link

slrz commented Apr 6, 2021

You might want to read up on the github.com/[Ss]irupsen/logrus saga.

@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 6, 2021
@jba
Copy link
Contributor

jba commented Apr 6, 2021

The go.mod file at the latest version uses PageDuty, so the all-lower path is an alternative path. I think we should redirect to the correct path.

@jba jba modified the milestones: Unreleased, pkgsite/unplanned Apr 6, 2021
@tonglil
Copy link
Author

tonglil commented Apr 6, 2021

I'm familiar with it, but not sure what you want me to do about it @slrz?
I'm not the owner of these packages.

@julieqiu
Copy link
Member

@tiegz
Copy link

tiegz commented Mar 14, 2022

Hey all, let me know if I should open a new issue for this, but:

Given a module with canonical url github.com/go-sql-driver/mysql (ref: https://github.com/go-sql-driver/mysql/blob/master/go.mod):

Since Go Modules is case-sensitive it seems like only https://pkg.go.dev/github.com/go-sql-driver/mysql should be a valid url.

@tiegz
Copy link

tiegz commented Mar 14, 2022

Just got an answer in slack that the wrong versions work because they're using pre-Modules versions of that package 👍🏻 (still confused about the canonical version not working initially though).

@golang golang locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants