Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag: use strings.Builder instead of concatenating strings #45392

Closed
jamespfennell opened this issue Apr 5, 2021 · 2 comments
Closed

flag: use strings.Builder instead of concatenating strings #45392

jamespfennell opened this issue Apr 5, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@jamespfennell
Copy link
Contributor

There is a single function in the flag package whose implementation uses string concatenation instead of the recommended strings.Builder. The function was last touched before strings.Builder was introduced in Go 1.10, which explains the old style code.

I am about to propose a PR to migrate the function to strings.Builder; filing this for tracking purposes.
@jamespfennell jamespfennell mentioned this issue Apr 5, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/307329 mentions this issue: flag: use strings.Builder instead of concatenating strings

@ianlancetaylor
Copy link
Contributor

Note that it's not necessary to file an issue for a change that does not affect anything user visible. It's OK to just send the change. But filing an issue is OK too. Thanks.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 6, 2021
@dmitshur dmitshur added this to the Go1.17 milestone Apr 6, 2021
@golang golang locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

Successfully merging a pull request may close this issue.

flag: use strings.Builder instead of concatenating strings jamespfennell/go
4 participants
@dmitshur @ianlancetaylor @gopherbot @jamespfennell