Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Remove packages github.com/palchukovsky/ss-go/* #45382

Closed
palchukovsky opened this issue Apr 4, 2021 · 4 comments
Closed

x/pkgsite: Remove packages github.com/palchukovsky/ss-go/* #45382

palchukovsky opened this issue Apr 4, 2021 · 4 comments
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
pkgsite/package-r...

Comments

@palchukovsky
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/search?page=2&q=palchukovsky%2Fss-go%2F%2A

What did you do?

Many packages github.com/palchukovsky/ss-go/* were created by automation error and were added to the proxy cache.

It creates many errors "ambiguous import" in module dependency tree.

Now modules have removed from repository, but not from the cache.

What did you expect to see?

All modules with path github.com/palchukovsky/ss-go/* except github.com/palchukovsky/ss-go is removed from the proxy.
@gopherbot gopherbot added this to the Unreleased milestone Apr 4, 2021
@jba
Copy link
Contributor

jba commented Apr 5, 2021

Unfortunately we can't remove github.com/palchukovsky/ss-go/* without also removing github.com/palchukovsky/ss-go.

I will remove the following:

github.com/palchukovsky/ss-go/api
github.com/palchukovsky/ss-go/lambda
github.com/palchukovsky/ss-go/lib

Those paths and anything under them will be removed, and no new packages with those paths as a prefix will be allowed. However, a new package like github.com/palchukovsky/ss-go/foo will be allowed.

@jba
Copy link
Contributor

jba commented Apr 5, 2021

Done.

@jba jba closed this as completed Apr 5, 2021
@palchukovsky
Copy link
Author

Thank you! But - is it possible to remove the whole github.com/palchukovsky/ss-go from the cache (and all sub-pathes) and then allow work with it from the scratch, without any disallowing for future naming?

@jba
Copy link
Contributor

jba commented Apr 5, 2021

The short answer is no. We could of course remove things from our database, but the problem is that our database is designed to be a reflection of the Go module proxy. Sometimes we reprocess all or some of our data from the proxy, so we'd encounter your packages again and add them again. That is why we keep a prefix-based list of exclusions that is always in force.

@hyangah hyangah added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 20, 2022
@golang golang locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
pkgsite/package-removal
Development

No branches or pull requests
5 participants
@hyangah @julieqiu @gopherbot @palchukovsky @jba