Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: consistent slash to search #45268

Closed
jakesylvestre opened this issue Mar 28, 2021 · 2 comments
Closed

x/pkgsite: consistent slash to search #45268

jakesylvestre opened this issue Mar 28, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite

Comments

@jakesylvestre
Copy link

jakesylvestre commented Mar 28, 2021

Currently, slash to search doesn't work on the main page

What did you do?

I went to the main page and typed slash to search

What did you expect to see?

I expected a search prompt like on any other page, for example:

netutils · pkg go dev

What did you see instead?

No slash to search on the home page

go dev

@gopherbot gopherbot added this to the Proposal milestone Mar 28, 2021
@jakesylvestre jakesylvestre changed the title proposal: x/pkgsite slash to search proposal: x/pkgsite: slash to search Mar 28, 2021
@jakesylvestre jakesylvestre changed the title proposal: x/pkgsite: slash to search proposal: x/pkgsite: slash to search on main page Mar 28, 2021
@jakesylvestre jakesylvestre changed the title proposal: x/pkgsite: slash to search on main page proposal: x/pkgsite: consistent slash to search Mar 28, 2021
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Mar 31, 2021
@rsc
Copy link
Contributor

rsc commented Mar 31, 2021

/cc @julieqiu

This doesn't need to be in the proposal process. The website team can figure it out.

@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Proposal labels Mar 31, 2021
@ianlancetaylor ianlancetaylor removed this from Incoming in Proposals (old) Mar 31, 2021
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Mar 31, 2021
@ianlancetaylor ianlancetaylor changed the title proposal: x/pkgsite: consistent slash to search x/pkgsite: consistent slash to search Mar 31, 2021
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Mar 31, 2021
@julieqiu
Copy link
Member

julieqiu commented May 7, 2021

Closing this as a duplicate of #42704.

@julieqiu julieqiu closed this as completed May 7, 2021
@golang golang locked and limited conversation to collaborators May 7, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants