Fix: If you want to know whether clang is being used, search the filename, not the entire path.

  if strings.Contains(argv[0], "clang") {
  	argv = append(argv, "-Qunused-arguments")
  }

I think I understand your problem, but I'm not sure I followed what you meant here with the "fix'.

I guess we could check if the C linker is clang by running $CC -v or something.
cc @thanm

maybe it should have been strings.Contains(filepath.Base(argv[0]), "clang") ?

Fix: If you want to know whether clang is being used, search the filename, not the entire path.

  if strings.Contains(argv[0], "clang") {
  	argv = append(argv, "-Qunused-arguments")
  }

I think I understand your problem, but I'm not sure I followed what you meant here with the "fix'.

I guess we could check if the C linker is clang by running $CC -v or something.
cc @thanm

Something like:

	path := "/some/path/with/clang/in/it"
	file := filepath.Base(path)
	if strings.Contains(file, "clang") {
		fmt.Println("is clang")
	} else {
		fmt.Println("not clang")
	}

What if we just use linkerFlagSupported rather than trying to guess whether the linker is clang?

Change https://golang.org/cl/304692 mentions this issue: cmd/link/internal/id: use linkerFlagSupported to check -Qunused-arguments