Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http/httpproxy: http_proxy breaking changes in 1.16.x #45227

Closed
lz-dc opened this issue Mar 25, 2021 · 2 comments
Closed

x/net/http/httpproxy: http_proxy breaking changes in 1.16.x #45227

lz-dc opened this issue Mar 25, 2021 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@lz-dc
Copy link

lz-dc commented Mar 25, 2021

What version of Go are you using (go version)?

$ go version
go1.16.2

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
All

What did you do?

https://play.golang.org/p/cmTZDVvftc5

What did you expect to see?

The above sample code works fine with go1.15.8

What did you see instead?

The flow fails to use the proxy.
@gopherbot gopherbot added this to the Unreleased milestone Mar 25, 2021
@seankhliao
Copy link
Member

This is an intentional change as part of #40909 and documented in the 1.16 release notes:

The ProxyFromEnvironment function no longer returns the setting of the HTTP_PROXY environment variable for https:// URLs when HTTPS_PROXY is unset.

Closing as working as intended

@lz-dc
Copy link
Author

lz-dc commented Mar 25, 2021 •
edited

This is an intentional change as part of #40909 and documented in the 1.16 release notes:

The ProxyFromEnvironment function no longer returns the setting of the HTTP_PROXY environment variable for https:// URLs when HTTPS_PROXY is unset.

Closing as working as intended

What was the rationale behind this? http/https proxy is not tied to the end-point and enterprise configure http proxy for both non-ssl and ssl end-points.

This changes the earlier behaviour and causes regression.

@golang golang locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @lz-dc