Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go env" output should include GOEXPERIMENT #45226

Closed
mdempsky opened this issue Mar 25, 2021 · 8 comments
Closed

cmd/go: "go env" output should include GOEXPERIMENT #45226

mdempsky opened this issue Mar 25, 2021 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@mdempsky
Copy link
Member

/cc @aclements @bcmills

@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 25, 2021
@mdempsky mdempsky added this to the Go1.17 milestone Mar 25, 2021
@oiooj
Copy link
Member

oiooj commented Mar 25, 2021

Do we need to add this environment into go help environment ?

@mdempsky
Copy link
Member Author

I think that's fine, as long as it's made clear that it's for enabling experimental features that aren't supported or guaranteed to work and may change incompatibly or go away entirely in future releases.

I'd also recommend not listing available experiments. If necessary, point users towards cmd/internal/objabi.

@gopherbot
Copy link

Change https://golang.org/cl/304350 mentions this issue: cmd/go/internal/envcmd: add GOEXPERIMENT environment in env cmd

@ianlancetaylor ianlancetaylor modified the milestones: Go1.17, Backlog Apr 19, 2021
@gopherbot
Copy link

Change https://golang.org/cl/328751 mentions this issue: cmd/go: add GOEXPERIMENT to go env output

@mdempsky mdempsky modified the milestones: Backlog, Go1.17 Jun 18, 2021
@mdempsky
Copy link
Member Author

I don't know why this got moved off the Go 1.17 milestone. I think it's important for user reports that go env indicate whether they've tampered with experiments.

@toothrot
Copy link
Contributor

@mdempsky @bcmills Anything else to do before merging this change? The RC date is soon.

@mdempsky
Copy link
Member Author

@toothrot I have a change for it, I just need to rebase it on top of the fix that was merged for #46815 for Go 1.17.

I plan to do that after mailing out CLs for #46742. I expect to have CLs for both of these out by EOD.

@mdempsky
Copy link
Member Author

Okay, CLs 331109, 329654, and 328751 are mailed out for this issue.

@bcmills already approved the third only before rebasing. It's substantially unmodified by the rebase, so I think that CR+2 is still valid. I think just the first 2 need review.

@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants