Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: doesn't pick the same Change-Id line as Gerrit when a CL commit message contains more than one such line #45213

Open
dmitshur opened this issue Mar 24, 2021 · 1 comment
Open

x/build/maintner: doesn't pick the same Change-Id line as Gerrit when a CL commit message contains more than one such line #45213

dmitshur opened this issue Mar 24, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

In CL 301589 patch set 3, there were 2 Change-Id lines.

[...]
Change-Id: Ia979f971b9bf581b230d7d240ad4068e594eefe0
[...]
Change-Id: I5e1cd3357a5ae202a902060935b99fd1a821ba59

In that particular case, Gerrit uses the second one, while maintner picks the first one.

There's a TODO in the code:

// TODO: git footers are treated as multimaps. Account for this.

It's rare for a CL to have more than one Change-Id line with different IDs, so this doesn't come up often.

CC @golang/release.
@dmitshur dmitshur added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Mar 24, 2021
@dmitshur dmitshur added this to the Backlog milestone Mar 24, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 24, 2021
@gopherbot
Copy link

Change https://golang.org/cl/310012 mentions this issue: maintner: pick the lowermost Change-Id line

@dmitshur dmitshur mentioned this issue Apr 26, 2021
Closed
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot