Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: Wrap error in NewClientConn #45207

Open
avorima opened this issue Mar 24, 2021 · 6 comments
Open

x/crypto/ssh: Wrap error in NewClientConn #45207

avorima opened this issue Mar 24, 2021 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@avorima
Copy link

avorima commented Mar 24, 2021

What version of Go are you using (go version)?

$ go version
go version go1.15.10 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mv/.cache/go-build"
GOENV="/home/mv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/mv/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mv/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/mv/.local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/mv/.local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build650852416=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/CdUXyBdUq2g

What did you expect to see?

Using type assertion or errors.As for things like *net.OpError on errors returned by NewClientConn works.

What did you see instead?

The returned error is a *errors.errorString due to the fact that it's returned using fmt.Errorf and %v instead of %w.
@gopherbot gopherbot added this to the Unreleased milestone Mar 24, 2021
@networkimprov
Copy link

cc @FiloSottile

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 29, 2021
@avorima
Copy link
Author

avorima commented Apr 5, 2021

I see that simply changing the %v to %w won't work due to backwards compatibility issues, so I would propose adding a typed error in the ssh package that implements Unwrap to support error unwrapping for go versions > 1.13 and otherwise behaves like a normal errors.errorString.

@hopehook hopehook mentioned this issue Mar 5, 2022
Closed
@nvx
Copy link

nvx commented Nov 3, 2022

I see that simply changing the %v to %w won't work due to backwards compatibility issues, so I would propose adding a typed error in the ssh package that implements Unwrap to support error unwrapping for go versions > 1.13 and otherwise behaves like a normal errors.errorString.

I'm not sure why changing %v to %w would cause a backwards compatibility issue? The output string from the Error() call is the same. If you mean with pre-1.13 versions, I thought that wouldn't matter being outside of the support lifetime? (and I imagine the /x/ packages have even less guarantees). The go.mod references 1.17 already.

@avorima
Copy link
Author

avorima commented Nov 3, 2022 •
edited

@nvx Yes, backwards compatibility is no longer an issue, so then this would be a 1 line change.

@gopherbot
Copy link

Change https://go.dev/cl/448595 mentions this issue: ssh: wrap errors

@psanford
Copy link

I have some code that wants to check if a Dial error is due to my HostKeyCallback or for some other reason. This change would simplify my code by being able to simply use errors.Is/As.

jwebb pushed a commit to XTXMarkets/crypto that referenced this issue Apr 27, 2023
Wrap error that may come from a callback
3d852f0 
Fixes upsteam bug golang/go#45207, which
already has a open PR that's been blocked for months.
bwhmather pushed a commit to XTXMarkets/crypto that referenced this issue Jul 13, 2023
Wrap error that may come from a callback
efed6ba 
Fixes upsteam bug golang/go#45207, which
already has a open PR that's been blocked for months.
bwhmather pushed a commit to XTXMarkets/crypto that referenced this issue Aug 23, 2023
Wrap error that may come from a callback
2592874 
Fixes upsteam bug golang/go#45207, which
already has a open PR that's been blocked for months.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@psanford @cagedmantis @networkimprov @nvx @gopherbot @avorima