Skip to content

cmd/go: "internal/abi" needs to be compiled with "-+" #45144

New issue
New issue
Closed
Closed
cmd/go: "internal/abi" needs to be compiled with "-+"#45144
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.release-blocker
Milestone
Go1.17
@mdempsky

Description

@mdempsky
mdempsky
opened on Mar 20, 2021
Contributor

Packages that package runtime depends on are supposed to be compiled with -+ so the compiler knows to do some runtime-specific behavior. cmd/go has a hard-coded list of known packages that runtime depends on, but this wasn't updated when "internal/abi" was added:

go/src/cmd/go/internal/work/gc.go

Lines 90 to 100 in e0fae78

compilingRuntime := p.Standard && (p.ImportPath == "runtime" || strings.HasPrefix(p.ImportPath, "runtime/internal"))
// The runtime package imports a couple of general internal packages.
if p.Standard && (p.ImportPath == "internal/cpu" || p.ImportPath == "internal/bytealg") {
compilingRuntime = true
}
if compilingRuntime {
// runtime compiles with a special gc flag to check for
// memory allocations that are invalid in the runtime package,
// and to implement some special compiler pragmas.
gcargs = append(gcargs, "-+")
}

We should update the list, and add a test to make sure they don't fall out of sync again in the future.

Alternatively, cmd/go can just use its knowledge of which packages runtime depends on.

/cc @bcmills @mknyszek

Activity

mdempsky
added
NeedsFixThe path to resolution is known, but the work has not been done.
on Mar 20, 2021
mdempsky
added this to the Go1.17 milestone on Mar 20, 2021
bcmills
added
release-blocker
on Mar 24, 2021
gopherbot

gopherbot commented on Mar 31, 2021

@gopherbot
gopherbot
on Mar 31, 2021
Contributor

Change https://golang.org/cl/306289 mentions this issue: go/src/cmd/go/internal/work: compile "internal/abi" with "-+"

gopherbot
closed this as completedin 2d88f8fon Apr 2, 2021
golang
locked and limited conversation to collaborators on Apr 2, 2022
gopherbot
added
FrozenDueToAge
on Apr 2, 2022
salewski
added a commit that references this issue on Apr 29, 2024

go/src/cmd/go/internal/work: compile "internal/abi" with "-+"

2d88f8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.release-blocker

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mdempsky@bcmills@gopherbot

        Issue actions
          cmd/go: "internal/abi" needs to be compiled with "-+" · Issue #45144 · golang/go