x/pkgsite: ignore import path casing #45140
Comments
seankhliao
changed the title
|
I would recommend asking the authors to request for github.com/ReactiveX/RxG to be excluded from pkg.go.dev, per https://go.dev/about#removing-a-package. The reason that both versions appear is because github.com/ReactiveX/RxG does not have a go.mod file at v1.0.0. At that version, both A go.mod file was added in ReactiveX/RxGo@0994d7f#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 for v2, with the module path Once the go.mod file was added, github.com/ReactiveX/RxGo/v2 was no longer a valid module path. https://pkg.go.dev/github.com/ReactiveX/RxGo/v2 redirects to https://pkg.go.dev/github.com/reactivex/rxgo/v2 as a result. |
julieqiu
added
the
WaitingForInfo
|
Just to add to Julie's comments: case is, and always has been, significant in import paths. Thus it would be wrong for us (or any go tool) to treat paths case-insensitively. GitHub does treat repo URLs case-insensitively, which causes the kind of problems you're seeing. The presence of a go.mod file fixes those problems by establishing the definitive import path. But without the go.mod file, pkg.go.dev (or any go tool) cannot tell what the right import path is. |
pkg.go.dev regards the case of the package import path
see examples below
What version of Go are you using (
go version)?irrelevant
Does this issue reproduce with the latest release?
irrelevant
What operating system and processor architecture are you using (
go env)?irrelevant
What did you do?
irrelevant
What did you expect to see?
https://pkg.go.dev/github.com/reactivex/rxgo
https://pkg.go.dev/github.com/ReactiveX/RxGo
no difference between pages by these 2 links
What did you see instead?
https://pkg.go.dev/github.com/ReactiveX/RxGo - does not contain info about v2
This is actually very confusing. I've spent some time learning RxGo v1, because the link above said it's the latest version... :(
The text was updated successfully, but these errors were encountered: