Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: create a unified header #45132

Closed
jamalc opened this issue Mar 19, 2021 · 1 comment
Closed

x/pkgsite: create a unified header #45132

jamalc opened this issue Mar 19, 2021 · 1 comment
Labels
FrozenDueToAge pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite

Comments

@jamalc
Copy link

jamalc commented Mar 19, 2021

Maintaining two separate header components is cumbersome and the fixed header requires accessibility hacks to remove it from the accessibility tree. We can use the sticky position css attribute with some simple transitions to achieve the same effect. This change will simplify header maintenance and create a more unified experience for mouse and keyboard users.

@jamalc jamalc added the pkgsite label Mar 19, 2021
@jamalc jamalc added this to the pkgsite/frontend milestone Mar 19, 2021
@jamalc jamalc self-assigned this Mar 19, 2021
@gopherbot
Copy link

Change https://golang.org/cl/303412 mentions this issue: content/static: consolidate header into single component

@golang golang locked and limited conversation to collaborators Mar 19, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants