Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: adjust type checking of string(1 << s) pending issue #45114 #45117

Closed
griesemer opened this issue Mar 19, 2021 · 4 comments
Closed

go/types, types2: adjust type checking of string(1 << s) pending issue #45114 #45117

griesemer opened this issue Mar 19, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@griesemer
Copy link
Contributor

Reminder issue: Currently both go/types and types2 accept string(1 << s) while the compilers don't.

For details see #45114.

cc: @findleyr
@griesemer griesemer added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 19, 2021
@griesemer griesemer added this to the Backlog milestone Mar 19, 2021
@griesemer griesemer self-assigned this Mar 19, 2021
@griesemer
Copy link
Contributor Author

If we disallow this, re-enable the disabled test in test/fixedbugs/bug193.go.

@gopherbot
Copy link

Change https://golang.org/cl/303094 mentions this issue: test: enable fixedbugs/bug193.go for -G compiler option

gopherbot pushed a commit that referenced this issue Mar 23, 2021
@griesemer
test: enable fixedbugs/bug193.go for -G compiler option
f4b9183 
Temporarily disable a questionable test case in fixedbugs/bug193.go
and enable the test as a whole. See the issues below for details.

Updates #45114.
Updates #45117.

Change-Id: I1de6f8d79b592eeeec139cd92b6c9cac56a9a74b
Reviewed-on: https://go-review.googlesource.com/c/go/+/303094
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@griesemer griesemer mentioned this issue Jan 18, 2022
Closed
@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jan 18, 2022
@griesemer griesemer modified the milestones: Backlog, Go1.18 Jan 18, 2022
@griesemer griesemer mentioned this issue Jan 18, 2022
Closed
@gopherbot
Copy link

Change https://golang.org/cl/379256 mentions this issue: go/types, types2: report error for invalid string(1 << s)

@gopherbot
Copy link

Change https://golang.org/cl/379274 mentions this issue: cmd/compile/internal/types2: use orig. compiler error message for a shift error

gopherbot pushed a commit that referenced this issue Jan 19, 2022
@griesemer
go/types, types2: use orig. compiler error message for a shift error
1efc581 
Slightly better for cases such as string(1 << s).
Leaves type-checker tests alone for now because
there are multiple dozens.

For #45117.

Change-Id: I47b314c713fabe424c2158674bf965416a8a6f5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/379274
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
@griesemer @jproberts
go/types, types2: report error for invalid string(1 << s)
3483699 
For golang#45114.
Fixes golang#45117.

Change-Id: I71d6650ae2c4c06952fce19959120f15f13c08a2
Reviewed-on: https://go-review.googlesource.com/c/go/+/379256
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
jproberts pushed a commit to jproberts/go that referenced this issue Jun 21, 2022
@griesemer @jproberts
go/types, types2: use orig. compiler error message for a shift error
d68da8f 
Slightly better for cases such as string(1 << s).
Leaves type-checker tests alone for now because
there are multiple dozens.

For golang#45117.

Change-Id: I47b314c713fabe424c2158674bf965416a8a6f5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/379274
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@griesemer @gopherbot