Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: regression in source.fixAll diagnostics #45111

Closed
stamblerre opened this issue Mar 18, 2021 · 1 comment
Closed

x/tools/gopls: regression in source.fixAll diagnostics #45111

stamblerre opened this issue Mar 18, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.10

Comments

@stamblerre
Copy link
Contributor

Some source.fixAll and quickfix diagnostics are now labeled as only quickfix, even when we should return source.fixAll diagnostics so that they can be applied on save. This is preventing fillreturns quick fixes from being applied on save.

/cc @heschik
@stamblerre stamblerre added this to the gopls/v0.6.9 milestone Mar 18, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 18, 2021
@gopherbot
Copy link

Change https://golang.org/cl/303209 mentions this issue: internal/lsp: fix support for SourceFixAll code actions

@golang golang locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.10
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot