Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: incorrect major version in banner for gopkg.in packages #45098

Closed
julieqiu opened this issue Mar 18, 2021 · 3 comments
Closed

x/pkgsite: incorrect major version in banner for gopkg.in packages #45098

julieqiu opened this issue Mar 18, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Mar 18, 2021 •
edited

What is the URL of the page with the issue?

https://pkg.go.dev/gopkg.in/yaml.v2 and https://pkg.go.dev/gopkg.in/yaml.v3

Screenshot

image

What did you expect to see?

No banner, because the highest tagged major version is v2.

https://pkg.go.dev/gopkg.in/yaml.v3 should have a banner saying The highest tagged major version is v2. (without the extra dot in front of the major version).

What did you see instead?

A banner showing The highest tagged major version is .v3., with an extra dot in front of "v3":
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2021
@julieqiu julieqiu changed the title x/pkgsite: extra dot in highest major version banner for gopkg.in packages x/pkgsite: incorrect major version in banner for gopkg.in packages Mar 18, 2021
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 18, 2021
@gopherbot
Copy link

Change https://golang.org/cl/302950 mentions this issue: internal/postgres: ignore untagged versions for latest major

gopherbot pushed a commit to golang/pkgsite that referenced this issue Mar 18, 2021
@jba
internal/postgres: ignore untagged versions for latest major
bd41dbe 
When finding the latest major version of a unit, do not
consider untagged (that is, pseudo) versions.

For golang/go#45098

Change-Id: Ic38480f68edbe2a3db189bc3055ae75b3d5df72b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/302950
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/302951 mentions this issue: internal/frontend: use common function for major version

gopherbot pushed a commit to golang/pkgsite that referenced this issue Mar 19, 2021
@jba
internal/frontend: use common function for major version
a3acbfb 
Define a function to get the major version from a module path in a
clean way, and use it.

For golang/go#45098

Change-Id: I0a5053a763cf93dbd076ca4e0adc68d9c1bfb7f0
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/302951
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
@jba
Copy link
Contributor

jba commented Apr 4, 2021

Fix is live.

@jba jba closed this as completed Apr 4, 2021
@golang golang locked and limited conversation to collaborators Apr 4, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba