-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: TestStructHash, TestArrayHash etc failing on plan9-arm #45090
Comments
Weird that this is happening on this 32-bit platform and not others. |
This will affect on plan9/386 too. Lines 326 to 329 in f5e6d3e
This will always had 0 in the first byte. We have three options for this issue:
p.s. plan9 has /dev/random file which we can read from. https://9fans.github.io/plan9port/man/man3/rand.html |
Change https://golang.org/cl/302909 mentions this issue: |
CL 6386 is relevant. Plan9 used to read from /dev/random before that CL, but that was intentionally removed because it was "slow and [...] may block". Perhaps things have changed since 2015 though. |
CL 6386 is right.
|
@wangyi-fudan Any idea how can we initial hashkey without any entropy input? |
I don't think that's specific to GCE. At some point, I wrote randfs, which replaces If we're going to use the Plan 9's I'd prefer options 2. or 3. |
What exactly is the requirement for the output produced by |
For wyhash it only needs a non-zero integer to "mix" (xor + multiply) |
Change https://golang.org/cl/303969 mentions this issue: |
After CL280372, hash tests are failing on plan9-arm:
Also failing in hash/maphash:
The text was updated successfully, but these errors were encountered: