Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: TestClientHandshakeContextCancellation failures with "Unexpected client handshake error: EOF" #45084

Closed
bcmills opened this issue Mar 17, 2021 · 4 comments
Closed

crypto/tls: TestClientHandshakeContextCancellation failures with "Unexpected client handshake error: EOF" #45084

bcmills opened this issue Mar 17, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 17, 2021 

--- FAIL: TestClientHandshakeContextCancellation (0.00s)
    handshake_client_test.go:2537: Unexpected client handshake error: EOF
    handshake_client_test.go:2547: Client connection was not closed when the context was canceled
FAIL
FAIL	crypto/tls	2.556s

2021-03-17T07:01:00-72b501c/linux-amd64-race
2021-03-17T00:18:28-63b0a0a/android-amd64-emu
2021-03-16T19:23:36-d206ca5/linux-amd64-nocgo
2020-12-16T02:14:48-08b5091/linux-amd64
2020-12-14T17:26:06-ce61ccc/android-amd64-emu
2020-12-11T22:02:02-1430552/plan9-arm
2020-12-10T21:08:17-e0d20e5/plan9-arm
2020-12-10T15:37:33-b110733/plan9-arm
2020-12-09T01:34:53-ae9b442/plan9-arm
2020-12-07T23:44:44-6362d01/plan9-arm
2020-12-07T22:16:21-9b8c272/plan9-arm
2020-12-02T23:05:56-48838c3/plan9-arm
2020-12-02T16:33:57-c32140f/plan9-arm
2020-12-01T21:42:10-7fca39a/plan9-arm
2020-12-01T20:42:53-20e2518/plan9-arm
2020-12-01T19:31:47-212d385/plan9-arm
2020-11-30T17:21:22-294c214/android-amd64-emu
2020-11-28T02:31:54-b94346e/plan9-arm
2020-11-25T19:46:00-4481ad6/linux-mips64-rtrk
2020-11-24T00:50:11-762eda3/plan9-arm
2020-11-20T18:29:46-676f0a4/plan9-arm
2020-11-19T17:28:05-c315403/netbsd-386-9_0
2020-11-18T22:12:57-5b0ec1a/linux-mipsle-rtrk
2020-11-18T20:12:03-b4f3d52/android-amd64-emu
2020-11-18T14:41:53-64ef848/plan9-arm
2020-11-16T21:06:29-97700ba/android-amd64-emu
2020-11-14T17:24:37-92c732e/linux-mips-rtrk
2020-11-14T14:11:56-782cf56/plan9-arm
2020-11-09T20:41:26-8badef4/plan9-arm

CC @FiloSottile @katiehockman @rolandshoemaker
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 17, 2021
@bcmills bcmills added this to the Backlog milestone Mar 17, 2021
@katiehockman
Copy link
Contributor

It looks like this was introduced by 8607043. Perhaps the test is flaky.

/cc @johanbrandhorst

@bcmills bcmills modified the milestones: Backlog, Go1.17 Mar 17, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Mar 17, 2021

If the test is new in 1.17, this should probably be a 1.17 release-blocker. (We don't want users to encounter spurious failures if they run go test all.)

@johanbrandhorst
Copy link
Member

I'll remove the test until I can figure out how to fix it.

@gopherbot
Copy link

Change https://golang.org/cl/302569 mentions this issue: crypto/tls: remove flaky cancellation test

@katiehockman katiehockman mentioned this issue Mar 18, 2021
Closed
@golang golang locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@bcmills @johanbrandhorst @gopherbot @katiehockman