Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: pkg/proc/native package is missing from github.com/go-delve/delve/ #45067

Closed
hyangah opened this issue Mar 16, 2021 · 2 comments
Closed

x/pkgsite: pkg/proc/native package is missing from github.com/go-delve/delve/ #45067

hyangah opened this issue Mar 16, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 16, 2021

From https://pkg.go.dev/github.com/go-delve/delve@v1.6.1-0.20210315163646-333e84a0cb20/pkg/proc#section-directories
I noticed the directory is missing the native directory.
Screen Shot 2021-03-15 at 8 35 19 PM

https://github.com/go-delve/delve/tree/master/pkg/proc/native is the directory.
Suspected build constraints, but there are files without any build constraints.
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2021
@jba jba self-assigned this Mar 17, 2021
@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 17, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Mar 17, 2021
@jba
Copy link
Contributor

jba commented Mar 17, 2021

Some build contexts (js/wasm, for example) are deliberately broken by having files with two different package names. We currently treat this error as so serious that we shouldn't process the package at all, but it isn't. We should just ignore the bad build contexts and process the others.

@gopherbot
Copy link

Change https://golang.org/cl/302534 mentions this issue: internal/fetch: don't fail on bad build context

@golang golang locked and limited conversation to collaborators Mar 17, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @jba