Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: remove Scaleway builders #45066

Closed
cagedmantis opened this issue Mar 16, 2021 · 8 comments
Closed

x/build: remove Scaleway builders #45066

cagedmantis opened this issue Mar 16, 2021 · 8 comments
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. Builders x/build issues (builders, bots, dashboards) early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Go1.18

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Mar 16, 2021 •
edited

With the introduction of AWS ARM builders (#36841), we can now remove Scaleway as a hosting provider.
Removing Scaleway will allow us to stop running the scaleway application used to manage instances on the provider.

We will continue to use Scaleway as a provider until:

@golang/release @cherrymui
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm Issues solely affecting the 32-bit arm architecture. labels Mar 16, 2021
@cagedmantis cagedmantis added this to the Go1.17 milestone Mar 16, 2021
@findleyr findleyr mentioned this issue May 3, 2021
Closed
@dmitshur
Copy link
Contributor

This is currently in 1.17 milestone, but Go 1.15 will be supported throughout this milestone. Moving to 1.18 and adding early-in-cycle instead.

@dmitshur dmitshur modified the milestones: Go1.17, Go1.18 May 10, 2021
@dmitshur dmitshur added the early-in-cycle A change that should be done early in the 3 month dev cycle. label May 10, 2021
@cagedmantis
Copy link
Contributor Author

Scaleway has advised us that we should migrate away from the c1 instances before July 1, 2021. They are in the process of being deprecated.

@dmitshur dmitshur added this to Planned in Go Release Team May 25, 2021
@dmitshur dmitshur moved this from Planned to In Progress in Go Release Team May 25, 2021
@gopherbot
Copy link

Change https://golang.org/cl/325694 mentions this issue: dashboard, cmd/coordinator: remove all Scaleway builders

@gopherbot
Copy link

Change https://golang.org/cl/325693 mentions this issue: cmd/release: stop using scaleway for linux-arm

@gopherbot
Copy link

Change https://golang.org/cl/325696 mentions this issue: cmd/buildlet, cmd/upload: remove references to scaleway

@gopherbot
Copy link

Change https://golang.org/cl/325695 mentions this issue: env/linux-arm/scaleway, cmd/scaleway: remove scaleway command and image

@cagedmantis
Copy link
Contributor Author

Before the removal of Scaleway as a provider, the linux-arm-scaleway builder was used for the linux-armv6l release. It was configured to SkipTests during the release because the builder did not have enough resources to run the tests successfully.

	{
		GoQuery: "< go1.16beta1",
		OS:      "linux",
		Arch:    "arm",
		Builder: "linux-arm-scaleway",
		Goarm:   6, // For compatibility with all Raspberry Pi models.
		// The tests take too long for the release packaging.
		// Much of the time the whole buildlet times out.
		SkipTests: true,
	},

The set of changes introduced by this issue move the builder used to release linux-armv6l to the linux-arm-aws builder. With the use of this new builder we should enable test to run as we have previously done with for the Go 1.16 release. When we execute a simulated release for linux-armv6l on the release-branch.go1.15 ( at time of testing ab7f829), we run into a set of errors:

ok  	cmd/internal/test2json	0.202s
--- FAIL: TestPIESize (0.00s)
    --- FAIL: TestPIESize/TestPieSize-external (18.00s)
        elf_test.go:287: [/root/go/bin/go build -o /tmp/go-link-TestPieSize-external313361227/exeexternal -buildmode=exe -ldflags=-linkmode=external pie.go]
        elf_test.go:287: [/root/go/bin/go build -o /tmp/go-link-TestPieSize-external313361227/pieexternal -buildmode=pie -ldflags=-linkmode=external pie.go]
        elf_test.go:409: real size difference 0xfffffffffffffd4e, expected 0xfffffffffffffb0c
        elf_test.go:412: PIE unexpectedly large: got difference of 18446744073709550926 (2852468 - 2851560), expected difference 18446744073709550348
FAIL
FAIL	cmd/link	41.400s
ok  	cmd/link/internal/benchmark	0.034s
--- FAIL: TestRuntimeTypeAttrExternal (1.01s)
    dwarf_test.go:1022: DWARF type offset was 0x3b38+0x70a30, but test program said 0xc2d568
FAIL
FAIL	cmd/link/internal/ld	5.976s
ok  	cmd/link/internal/loader	0.039s
ok  	cmd/link/internal/sym	0.023s
--- FAIL: TestExternalLinkerCgoExec (2.02s)
    nm_test.go:189: want 0x958ac8 address for main.main symbol, but have 0xb4ac8
    nm_test.go:189: want 0xa13900 address for main.testdata symbol, but have 0x16f900
    nm_test.go:189: want 0x958aec address for main.testfunc symbol, but have 0xb4aec
FAIL
FAIL	cmd/nm	4.412s
ok  	cmd/objdump	3.419s

These same test failures were encountered when we began using the linux-arm-aws builder for the Go 1.16 and beyond #43202. I'm going to create a backport CL for the fix for that issue in hopes that it will resolve the problem.

gopherbot pushed a commit to golang/build that referenced this issue Jun 10, 2021
@cagedmantis
cmd/release: stop using scaleway for linux-arm
1a31fad 
The Scaleway hosts are in the process of being deprecated. This
removes the use of Scaleway for releases. The linux-arm-aws builders
will be used during the release for Linux ARM packages.

Updates golang/go#45066

Change-Id: I1a24917d48c36f8820845689636b4b718a7dc0a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/325693
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jun 10, 2021
@cagedmantis
dashboard, cmd/coordinator: remove all Scaleway builders
d3596bf 
Remove all builders hosted on Scaleway. This change also removes the
Scaleway coordinator health checks.

Fixes golang/go#22749
Updates golang/go#45066

Change-Id: If43fe7f971a2bd969fd7e5f98b4d945e610179e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/325694
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jun 10, 2021
@cagedmantis
env/linux-arm/scaleway, cmd/scaleway: remove scaleway command and image
a15467b 
Scaleway builders are no longer in use. The scaleway command is no
longer needed to manage instances. The image configuration for
Scaleway specific machines will be removed.

Updates golang/go#45066

Change-Id: I587ff909993e9c3a60a3c983d60269c931ab3ed1
Reviewed-on: https://go-review.googlesource.com/c/build/+/325695
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Go Release Team automation moved this from In Progress to Done Jun 10, 2021
@findleyr findleyr mentioned this issue Jun 28, 2021
Closed
@bcmills bcmills mentioned this issue Nov 11, 2021
Closed
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/408939 mentions this issue: cmd/rundockerbuildlet: remove Scaleway-specific configuration

gopherbot pushed a commit to golang/build that referenced this issue May 31, 2022
@dmitshur @gopherbot
cmd/rundockerbuildlet: remove Scaleway-specific configuration
5289972 
Scaleway builders are no longer in use, and most of their code was
removed in CL 325694 and CL 325695. This CL removes some more from
the rundockerbuildlet command.

Updates golang/go#45066.

Change-Id: I4b1902ffb8b20ca05f7d76dd041d889decc6f0b1
Reviewed-on: https://go-review.googlesource.com/c/build/+/408939
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. Builders x/build issues (builders, bots, dashboards) early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot