Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/poll: TestSplicePipePool failures on linux builders #45059

Closed
bcmills opened this issue Mar 16, 2021 · 9 comments
Closed

internal/poll: TestSplicePipePool failures on linux builders #45059

bcmills opened this issue Mar 16, 2021 · 9 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.17

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 16, 2021 

--- FAIL: TestSplicePipePool (1.07s)
    splice_linux_test.go:61: at least one pipe is still open
FAIL
FAIL	internal/poll	1.254s

2021-03-16T13:06:04-26c32de/linux-386-sid
2021-03-14T21:10:45-3cdd5c3/linux-arm

CC @panjf2000 @ianlancetaylor @bradfitz
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 16, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Mar 16, 2021

This test was added during the current release cycle (March 9, in CL 271537 for #42740), so marking as release-blocker for Go 1.17.

@bcmills bcmills added this to the Go1.17 milestone Mar 16, 2021
@panjf2000
Copy link
Member

This looks more like an episodic failure?

@bcmills
Copy link
Contributor Author

bcmills commented Mar 17, 2021

Yes, it is intermittent. An intermittent failure is nonetheless a failure.

@toothrot
Copy link
Contributor

toothrot commented Apr 1, 2021

@bcmills @panjf2000 Friendly ping as this issue is labeled as a release-blocker for Go 1.17.

@bcmills
Copy link
Contributor Author

bcmills commented Apr 7, 2021

@toothrot, I don't have the bandwidth to look into this at the moment. If no one else does either, then I suggest we roll back CL 271537 until it can be fixed.

@gopherbot
Copy link

Change https://golang.org/cl/308089 mentions this issue: Revert "internal/poll: implement a pipe pool for splice() call"

@ianlancetaylor
Copy link
Contributor

2021-04-07T03:42:11-8462169/android-arm-corellium
2021-04-06T20:28:21-b56177a/android-arm-corellium
2021-03-30T23:55:42-0fdd371/android-arm-corellium
2021-03-26T06:03:20-98a9023/android-arm-corellium
2021-03-24T21:20:10-179bcd7/linux-arm
2021-03-18T19:15:12-e4253cd/android-arm-corellium
2021-03-18T18:50:58-b95e4b7/linux-arm
2021-03-17T22:14:28-f38b642/android-arm-corellium
2021-03-16T13:06:04-26c32de/linux-386-sid
2021-03-14T21:10:45-3cdd5c3/linux-arm

@gopherbot
Copy link

Change https://golang.org/cl/308329 mentions this issue: internal/poll: bump up the number of iterations in the test loop

@bcmills bcmills mentioned this issue Apr 26, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/317510 mentions this issue: internal/poll: cast off the last reference of SplicePipe in test

gopherbot pushed a commit that referenced this issue May 7, 2021
@panjf2000 @ianlancetaylor
internal/poll: cast off the last reference of SplicePipe in test
832c70e 
Updates #45059

Change-Id: I9f377abcc7b77136ae6cf4896b968f73c758b559
Reviewed-on: https://go-review.googlesource.com/c/go/+/317510
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@bcmills bcmills mentioned this issue Aug 30, 2021
Closed
@golang golang locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
5 participants
@toothrot @ianlancetaylor @bcmills @panjf2000 @gopherbot