Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Unable to rescan to detect new license #45027

Closed
deefdragon opened this issue Mar 15, 2021 · 4 comments
Closed

x/pkgsite: Unable to rescan to detect new license #45027

deefdragon opened this issue Mar 15, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@deefdragon
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/sohlich/elogrus

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.82 Safari/537.36

Screenshot

Capture

What did you do?

Attempted to access the documentation for https://pkg.go.dev/github.com/sohlich/elogrus

What did you expect to see?

Documentation related to the package

What did you see instead?

A License error, and a last scanned date of 2017.

The package now has a valid MIT license on the master branch, and on the v7 tag.

@gopherbot gopherbot added this to the Unreleased milestone Mar 15, 2021
@jba jba self-assigned this Mar 15, 2021
@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 15, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Mar 15, 2021
@jba
Copy link
Contributor

jba commented Mar 15, 2021

The right path for your module, according to your go.mod file, begins with gopkg.in/sohlich/elogrus. https://pkg.go.dev/gopkg.in/sohlich/elogrus.v7 works fine.
The path starting with github.com is from before you had a go.mod file, and shouldn't be used.
If you'd like, we can remove it.

@deefdragon
Copy link
Author

Not my package, so I cant make a decision on its removal.

Would it be viable for packages that have a common source repository to be linked together somehow to prevent this in the future? Or some other form of detection of module path change? Its likely a rare edge case, but still infuriating if you are an outside user.

@jba
Copy link
Contributor

jba commented Mar 15, 2021

We do detect and reject modules whose path does not match the path in the go.mod file. The problem is that the github package doesn't have a go.mod file to check with. pkg.go.dev only knows about module zip files (except, as a heuristic, we try to link source to the originating repo), so there's no way to tell that the github path is "bad" here.

Filed sohlich/elogrus#35.

@deefdragon
Copy link
Author

Assuming nothing else needs to be taken care of then as it is now tracked in that ticket, closing this one.

@golang golang locked and limited conversation to collaborators Mar 15, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants