Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cloudfns/wikiwebhook: failing to publish to topic #44948

Closed
dmitshur opened this issue Mar 11, 2021 · 2 comments
Closed

x/build/cloudfns/wikiwebhook: failing to publish to topic #44948

dmitshur opened this issue Mar 11, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

The GitHubWikiChangeWebHook cloud function was recently redeployed with a newer Go runtime. After being redeployed, it has been failing to publish to Pub/Sub topic. From logs:

Unable to publish to topic: topic.Publish: rpc error: code = InvalidArgument desc = You have passed an invalid argument to the service (argument=).

Until this is fixed, https://groups.google.com/g/golang-wikichanges will not get new mail.

CC @golang/release, @ianlancetaylor.
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Mar 11, 2021
@dmitshur dmitshur added this to the Unreleased milestone Mar 11, 2021
@dmitshur dmitshur self-assigned this Mar 11, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 11, 2021
@dmitshur dmitshur added this to In Progress in Go Release Team Mar 11, 2021
@dmitshur
Copy link
Contributor Author

dmitshur commented Mar 12, 2021 •
edited

Found the problem (and mitigated; so removed Soon label).

When using an older Go runtime, the environment variable GCP_PROJECT was being set implicitly. With the newer Go runtime, it no longer is. See https://cloud.google.com/functions/docs/env-var#nodejs_8_python_37_and_go_111 and https://cloud.google.com/functions/docs/env-var#newer_runtimes.

I'll look into filing an issue about improving the error message from the pubsub client. Perhaps it's also viable to make it so that calling pubsub.NewClient(ctx, "") returns a non-nil error. (Reported googleapis/google-cloud-go#3828 for this.)

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Mar 12, 2021
@dmitshur dmitshur mentioned this issue Mar 17, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/302549 mentions this issue: cloudfns/wikiwebhook: set GCP_PROJECT env var explicitly

Go Release Team automation moved this from In Progress to Done Mar 18, 2021
@golang golang locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot