Skip to content

encoding/xml: infinite loop when using xml.NewTokenDecoder with a custom TokenReader [Go 1.15] #44914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
katiehockman opened this issue Mar 10, 2021 · 2 comments
Closed

encoding/xml: infinite loop when using xml.NewTokenDecoder with a custom TokenReader [Go 1.15] #44914

katiehockman opened this issue Mar 10, 2021 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Milestone
Go1.15.9

Comments

@katiehockman
Copy link
Contributor

The Decode, DecodeElement, and Skip methods of an xml.Decoder provided by xml.NewTokenDecoder may enter an infinite loop when operating on a custom xml.TokenReader which returns an EOF in the middle of an open XML element.

Thanks to Sam Whited for reporting this issue.
This issue is CVE-2021-27918.
@katiehockman katiehockman added Security CherryPickApproved Used during the release process for point releases labels Mar 10, 2021
@katiehockman katiehockman added this to the Go1.15.9 milestone Mar 10, 2021
@katiehockman
Copy link
Contributor Author

Fixed by 91062c2

@katiehockman
Copy link
Contributor Author

See #44913 for main issue

@SuperQ SuperQ mentioned this issue May 24, 2021
Closed
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Projects
None yet
Milestone
Go1.15.9
Development

No branches or pull requests
2 participants
@gopherbot @katiehockman